Skip to content

Commit

Permalink
Types: fx color and some nodes (#30325)
Browse files Browse the repository at this point in the history
Co-authored-by: Samuel Rigaud <[email protected]>
  • Loading branch information
s-rigaud and Samuel Rigaud authored Jan 14, 2025
1 parent a34d43c commit accd150
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
10 changes: 5 additions & 5 deletions src/nodes/accessors/TextureNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -384,11 +384,11 @@ class TextureNode extends UniformNode {
* @param {NodeBuilder} builder - The current node builder.
* @param {String} textureProperty - The texture property.
* @param {String} uvSnippet - The uv snippet.
* @param {String} levelSnippet - The level snippet.
* @param {String} biasSnippet - The bias snippet.
* @param {String} depthSnippet - The depth snippet.
* @param {String} compareSnippet - The compare snippet.
* @param {String} gradSnippet - The grad snippet.
* @param {String?} levelSnippet - The level snippet.
* @param {String?} biasSnippet - The bias snippet.
* @param {String?} depthSnippet - The depth snippet.
* @param {String?} compareSnippet - The compare snippet.
* @param {Array<String>?} gradSnippet - The grad snippet.
* @return {String} The generated code snippet.
*/
generateSnippet( builder, textureProperty, uvSnippet, levelSnippet, biasSnippet, depthSnippet, compareSnippet, gradSnippet ) {
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/core/Node.js
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ class Node extends EventDispatcher {
/**
* Returns the child nodes as a JSON object.
*
* @return {Object} The serialized child objects as JSON.
* @return {Array<Object>} An iterable list of serialized child objects as JSON.
*/
getSerializeChildren() {

Expand Down
10 changes: 6 additions & 4 deletions src/renderers/common/Color4.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ class Color4 extends Color {

/**
* Constructs a new four-component color.
* You can also pass a single THREE.Color, hex or
* string argument to this constructor.
*
* @param {Number|String} r - The red value.
* @param {Number} g - The green value.
* @param {Number} b - The blue value.
* @param {Number|String} [r=1] - The red value.
* @param {Number} [g=1] - The green value.
* @param {Number} [b=1] - The blue value.
* @param {Number} [a=1] - The alpha value.
*/
constructor( r, g, b, a = 1 ) {
Expand All @@ -28,7 +30,7 @@ class Color4 extends Color {

/**
* Overwrites the default to honor alpha.
* You can also passed a single THREE.Color, hex or
* You can also pass a single THREE.Color, hex or
* string argument to this method.
*
* @param {Number|String} r - The red value.
Expand Down

0 comments on commit accd150

Please sign in to comment.