SkinnedMesh: Added serialization/deserialization. #20589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful! |
|
Thanks! |
This was referenced Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
#16234
Description
This PR enables serialization/deserialization for
SkinnedMesh. It also enhances the editor to save/reload animations. It's now possible to save/reload scenes with skinned mesh without loosing their type information and animations.The change is a new attempt of #15413 however with an improved implementation. No changes to
BufferGeometryare necessary anymore and the code uses now a bone lookup table to create the skeletons (see https://github.com/mrdoob/three.js/pull/15413/files#r240787588).