SkinnedMesh/Skeleton: Added serialization/deserialization #15413
Conversation
| var array = Array.prototype.slice.call( attribute.array ); | ||
| var array; | ||
|
|
||
| if ( attribute.isInterleavedBufferAttribute ) { |
There was a problem hiding this comment.
This is necessary since some glTF models might have interleaved buffer data like in webgl_animation_skinning_blending. This code section creates normal BufferAttributes in order to ensure correct buffer data.
| // use the supplied bone inverses or calculate the inverses | ||
| this.boneMatrices = undefined; | ||
| this.boneTexture = undefined; | ||
| this.boneTextureSize = undefined; |
There was a problem hiding this comment.
Added all properties of Skeleton to the ctor to improve clarity.
|
|
||
| case 'Mesh': | ||
|
|
||
| var geometry = getGeometry( data.geometry ); | ||
| var material = getMaterial( data.material ); | ||
|
|
||
| if ( geometry.bones && geometry.bones.length > 0 ) { |
There was a problem hiding this comment.
This code is obsolete now.
|
@Mugen87 I wish you could notice me beforehand if you started to work on and use similar code to mine. Actually I was working on #11603 today, and ended up wasting my half day. Yeah, I can understand you didn't bother me, you thought I've been busy because I couldn't respond to anything for a while. But just in case I wanted you to let me know beforehand. |
| for ( var i = 0, l = json.bones.length; i < l; i ++ ) { | ||
|
|
||
| var boneUUID = json.bones[ i ]; | ||
| var bone = object.getObjectByProperty( 'uuid', boneUUID ); |
There was a problem hiding this comment.
Here can be slow if scene graph is big. Probably making bone lookup table with bone uuid in parseObject is good. I think it may be ok with optimizing when we receive the performance improvement request tho. Adding a comment about performance might be good so far?
| if ( this.isSkinnedMesh ) { | ||
|
|
||
| if ( this.bindMode !== undefined ) object.bindMode = this.bindMode; | ||
| if ( this.bindMatrix !== undefined ) object.bindMatrix = this.bindMatrix.toArray(); |
There was a problem hiding this comment.
I don't think .bindMode and .bindMatrix can be undefined here. Yeah more robust tho.
Sorry for that. Since you were not that active in the last weeks and noticed multiple time you were busy, I've decided to push this unit of work forward without an announcement.
I would not say you wasted your time. It's a good thing when more than a single developer deal with important stuff like this one. Similar to VAOs or triangulated lines 👍 |
|
Closing for now. If there is any interest in merging this approach (we might need a different one), I'll reopen and fix the merge conflicts. |
PR based on #11603 (thanks to @takahirox)
I have tested this PR with multiple examples (e.g.
webgl_animation_skinning_blending,webgl_loader_fbxorwebgl_loader_collada_skinning) and the serialization/deserialization seems to work. Unfortunately, I have encountered some problems that were really cumbersome to identify and fix^^.BTW: Before calling
SkinnedMesh.toJSON()it might be necessary to callObject3D.updateMatrixWorld()in order to ensure correct transformation matrices. This might be necessary ifObject3D.position,Object3D.scaleandObject3D.quaternionare not composed intoObject3D.matrixyet.