Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-existing default icons for FileAttachment annotations (issue 16800) #16801

Closed
wants to merge 1 commit into from

Conversation

Snuffleupagus
Copy link
Collaborator

The FileAttachment annotations in the referenced PDF document have /Graph Name-entries, which is a type that we don't provide a default icon for; see PR #15747.
In that case, since a non-existent icon is explicitly specified, it seems reasonable to fallback to no icon rather than "PushPin" as we currently do.

…ue 16800)

The FileAttachment annotations in the referenced PDF document have /Graph Name-entries, which is a type that we don't provide a default icon for; see PR 15747.
In that case, since a non-existent icon is explicitly specified, it seems reasonable to fallback to no icon rather than "PushPin" as we currently do.
@Snuffleupagus Snuffleupagus linked an issue Aug 8, 2023 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

On second thought, this is probably not entirely correct.
The FileAttachment annotations also have non-standard /CA and /ca entries, and we should probably take those into account when rendering the default icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant