Add default icons for FileAttachment annotations (bug 1230933) #15747
Conversation
|
For reference, this is how Adobe Reader handles the referenced PDF document (it doesn't include them when printing, hence we ought to be able to skip that as well):
|
Snuffleupagus
force-pushed
the
FileAttachment-icons
branch
3 times, most recently
from
1dfac95 to
6773380
Compare
*Please note:* This "borrows" the icons from Thunderbird. According to the PDF specification, see https://web.archive.org/web/20220309040754if_/https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G11.2096626, we should be providing default icons for FileAttachment annotations without appearances.
Snuffleupagus
force-pushed
the
FileAttachment-icons
branch
from
6773380 to
aa5b678
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d1f0d2a123ee2ef/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d1f0d2a123ee2ef/output.txt Total script time: 1.24 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a5d8ce4d43fd41a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3c822998de74f40/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a5d8ce4d43fd41a/output.txt Total script time: 25.48 mins
Image differences available at: http://54.241.84.105:8877/a5d8ce4d43fd41a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3c822998de74f40/output.txt Total script time: 32.97 mins
Image differences available at: http://54.193.163.58:8877/3c822998de74f40/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/42b5684575aead0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/54e097d9acccc3d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/42b5684575aead0/output.txt Total script time: 21.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/54e097d9acccc3d/output.txt Total script time: 25.30 mins
|
Please note: This "borrows" the icons from Thunderbird.
According to the PDF specification, see https://web.archive.org/web/20220309040754if_/https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G11.2096626, we should be providing default icons for FileAttachment annotations without appearances.