Fix npm arguments in dist-install task

[srmagura]

Fixes #15382 (for real). Cloning the repository and running gulp dist-install failed with the error

Error: command "npm" with parameters "install,build/dist/" exited with code 1

on Node 16.15.0, npm 8.19.1, and Ubuntu 22.04.

Credit to @cuiyc2000 for finding this fix.

[Snuffleupagus]

Considering that the existing command works just fine for me (and always has), it's not entirely clear why we need to change this?
Again, the commit message doesn't really contain any description of the underlying problem or links to resources explaining why such a change is necessary.

[yc-cui]

@Snuffleupagus Could you please tell us the exact node.js and npm version you are using ? Also, why you remove the browserify example?

[Snuffleupagus]

Could you please tell us the exact node.js and npm version you are using?

Considering that the existing code has worked for years, without any issues reported, there must be something that's changed (e.g. in Node.js) to necessitate changes here. Hence, as already mentioned in #15428 (review), if this change is indeed correct it ought to be possible to provide resources/links explaining why it's actually necessary.

Also, why you remove the browserify example?

How is that question relevant here!? Besides, PR #15388 already outlines in some detail why that's done.

[Snuffleupagus]

Unfortunately it seems that the changes in this patch breaks the following use-case, since the example doesn't load correctly:

• Run gulp server
• Run gulp dist-install
• Visit http://localhost:8888/examples/components/simpleviewer.html

Doing that against the master branch works just fine (at least on Windows), hence this most unfortunately doesn't look like a change we can consider here!

[srmagura]

As @cuiyc2000 said, what are your versions of Node and npm @Snuffleupagus?

[Snuffleupagus]

what are your versions of Node and npm

$ npm version
{
  npm: '8.1.4',
  node: '16.0.0',
  v8: '9.0.257.17-node.10',
  uv: '1.41.0',
  zlib: '1.2.11',
  brotli: '1.0.9',
  ares: '1.17.1',
  modules: '93',
  nghttp2: '1.42.0',
  napi: '8',
  llhttp: '6.0.0',
  openssl: '1.1.1k+quic',
  cldr: '39.0',
  icu: '69.1',
  tz: '2021a',
  unicode: '13.0',
  ngtcp2: '0.1.0-DEV',
  nghttp3: '0.1.0-DEV'
}

Furthermore, please keep in mind that Node.js 14 is still officially supported for some time longer.

---

The more relevant question here, as far as I'm concerned, is if you can successfully follow the steps outlined in #15428 (comment) with this patch applied?

[srmagura]

Created issue #15435 with the exact steps to reproduce this problem.