Remove the browserify example
#15388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch proposes removing the `browserify` example for the following reasons: - The last `browserify` release was almost two years ago, according to both https://github.com/browserify/browserify/releases and https://www.npmjs.com/package/browserify?activeTab=versions - The project no longer seems to be actively maintained, since so far this year there's only been *a single* (seemingly trivial) patch merged; see https://github.com/browserify/browserify/commits/master - Because of the previous points `browserify` doesn't support modern and up-to-date JavaScript features, as evident from e.g. issue 14731 and multiple issues found in https://github.com/browserify/browserify/issues - Our `browserify` example is most likely not very commonly used, judging by the very low volume of issues/PRs related to it. Looking at the `git` history of that example the only changes have been lint- or maintenance-related.[1] - Providing an example for a framework that's no longer actively maintained doesn't seem like a good idea in general, since we probably don't want to steer users towards using (possibly) older frameworks. - Given that we've never used `browserify` in the PDF.js project, it's also quite difficult to provide support for the example. --- [1] It's interesting to compare with the `webpack` example, since that's generated both issues *and* also PRs (for missing features) from users.
timvandermeij
approved these changes
Sep 3, 2022
|
This seem like perfectly valid reasons to me for removing it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch proposes removing the
browserifyexample for the following reasons:browserifyrelease was almost two years ago, according to both https://github.com/browserify/browserify/releases and https://www.npmjs.com/package/browserify?activeTab=versionsbrowserifydoesn't support modern and up-to-date JavaScript features, as evident from e.g. issue examples/browserify broken #14731 and multiple issues found in https://github.com/browserify/browserify/issuesbrowserifyexample is most likely not very commonly used, judging by the very low volume of issues/PRs related to it. Looking at thegithistory of that example the only changes have been lint- or maintenance-related.[1]browserifyin the PDF.js project, it's also quite difficult to provide support for the example.[1] It's interesting to compare with the
webpackexample, since that's generated both issues and also PRs (for missing features) from users.