[Editor] Update some strings (bug 1787299) #15378
Conversation
l10n/en-US/viewer.properties
Outdated
| editor_text_color=Color | ||
| editor_text_size=Size | ||
| editor_draw_color=Color | ||
| editor_draw_thickness=Thickness | ||
| editor_draw_opacity=Opacity |
There was a problem hiding this comment.
Here, and elsewhere, why are we changing the string-ids when the content doesn't actually change?
Won't this cause localizers to (unnecessarily) have to re-translate this?
Can we please just revert these changes?
There was a problem hiding this comment.
It was just to be consistent, i.e. avoid having some free_text and text.
I thought that adding a number was a bit ugly but if you're fine with that then I am too.
l10n/en-US/viewer.properties
Outdated
| editor_text.title=Text | ||
| editor_text_label=Text | ||
| editor_draw.title=Draw | ||
| editor_draw_label=Draw |
There was a problem hiding this comment.
Here, and elsewhere, I'm not crazy about the new string-ids. Basically it seems preferable to me if the string-ids themselves are still more inline with the actual code, since without prior knowledge it'd not be immediately obvious that e.g. "editor_draw" refers to the Ink-annotation.
It's perhaps a bit less nice, but how about something like this (a pattern we already use elsewhere)?
| editor_text.title=Text | |
| editor_text_label=Text | |
| editor_draw.title=Draw | |
| editor_draw_label=Draw | |
| editor_free_text2.title=Text | |
| editor_free_text2_label=Text | |
| editor_ink2.title=Draw | |
| editor_ink2_label=Draw |
calixteman
force-pushed
the
editor_strings
branch
from
4ff7d91 to
b1d56db
Compare
calixteman
changed the title
calixteman
force-pushed
the
editor_strings
branch
from
b1d56db to
b8fa789
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d1c1759a1ad6808/output.txt |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/7d462cfc3d7b59f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/78588cc35a1797e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d1c1759a1ad6808/output.txt Total script time: 2.24 mins Published |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/78588cc35a1797e/output.txt Total script time: 6.83 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7d462cfc3d7b59f/output.txt Total script time: 5.13 mins
|
No description provided.