Skip to content

Commit

Permalink
[Editor] Update some strings (bug 1788665)
Browse files Browse the repository at this point in the history
  • Loading branch information
calixteman committed Sep 1, 2022
1 parent e9bdbe4 commit 4ff7d91
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 32 deletions.
26 changes: 13 additions & 13 deletions l10n/en-US/viewer.properties
Original file line number Diff line number Diff line change
Expand Up @@ -251,21 +251,21 @@ printing_not_ready=Warning: The PDF is not fully loaded for printing.
web_fonts_disabled=Web fonts are disabled: unable to use embedded PDF fonts.

# Editor
editor_free_text.title=Add FreeText Annotation
editor_free_text_label=FreeText Annotation
editor_ink.title=Add Ink Annotation
editor_ink_label=Ink Annotation
editor_text.title=Text
editor_text_label=Text
editor_draw.title=Draw
editor_draw_label=Draw

free_text_default_content=Enter text
text_default_content=Start typing

# Editor Parameters
editor_free_text_color=Color
editor_free_text_size=Size
editor_ink_color=Color
editor_ink_thickness=Thickness
editor_ink_opacity=Opacity
editor_text_color=Color
editor_text_size=Size
editor_draw_color=Color
editor_draw_thickness=Thickness
editor_draw_opacity=Opacity

# Editor aria
editor_free_text_aria_label=FreeText Editor
editor_ink_aria_label=Ink Editor
editor_ink_canvas_aria_label=User-created image
editor_text_aria_label=Text Editor
editor_draw_aria_label=Draw Editor
editor_draw_canvas_aria_label=User-created image
6 changes: 3 additions & 3 deletions src/display/editor/freetext.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class FreeTextEditor extends AnnotationEditor {

static initialize(l10n) {
this._l10nPromise = new Map(
["free_text_default_content", "editor_free_text_aria_label"].map(str => [
["text_default_content", "editor_text_aria_label"].map(str => [
str,
l10n.get(str),
])
Expand Down Expand Up @@ -405,11 +405,11 @@ class FreeTextEditor extends AnnotationEditor {
this.enableEditing();

FreeTextEditor._l10nPromise
.get("editor_free_text_aria_label")
.get("editor_text_aria_label")
.then(msg => this.editorDiv?.setAttribute("aria-label", msg));

FreeTextEditor._l10nPromise
.get("free_text_default_content")
.get("text_default_content")
.then(msg => this.editorDiv?.setAttribute("default-content", msg));
this.editorDiv.contentEditable = true;

Expand Down
6 changes: 3 additions & 3 deletions src/display/editor/ink.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class InkEditor extends AnnotationEditor {

static initialize(l10n) {
this._l10nPromise = new Map(
["editor_ink_canvas_aria_label", "editor_ink_aria_label"].map(str => [
["editor_draw_canvas_aria_label", "editor_draw_aria_label"].map(str => [
str,
l10n.get(str),
])
Expand Down Expand Up @@ -589,7 +589,7 @@ class InkEditor extends AnnotationEditor {
this.canvas.className = "inkEditorCanvas";

InkEditor._l10nPromise
.get("editor_ink_canvas_aria_label")
.get("editor_draw_canvas_aria_label")
.then(msg => this.canvas?.setAttribute("aria-label", msg));
this.div.append(this.canvas);
this.ctx = this.canvas.getContext("2d");
Expand Down Expand Up @@ -623,7 +623,7 @@ class InkEditor extends AnnotationEditor {
super.render();

InkEditor._l10nPromise
.get("editor_ink_aria_label")
.get("editor_draw_aria_label")
.then(msg => this.div?.setAttribute("aria-label", msg));

const [x, y, w, h] = this.#getInitialBBox();
Expand Down
8 changes: 4 additions & 4 deletions web/l10n_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ const DEFAULT_L10N_STRINGS = {
web_fonts_disabled:
"Web fonts are disabled: unable to use embedded PDF fonts.",

free_text_default_content: "Enter text…",
editor_free_text_aria_label: "FreeText Editor",
editor_ink_aria_label: "Ink Editor",
editor_ink_canvas_aria_label: "User-created image",
text_default_content: "Start typing…",
editor_text_aria_label: "Text",
editor_draw_aria_label: "Draw",
editor_draw_canvas_aria_label: "User-created image",
};

function getL10nFallback(key, args) {
Expand Down
18 changes: 9 additions & 9 deletions web/viewer.html
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@
<div class="editorParamsToolbar hidden doorHangerRight" id="editorFreeTextParamsToolbar">
<div class="editorParamsToolbarContainer">
<div class="editorParamsSetter">
<label for="editorFreeTextColor" class="editorParamsLabel" data-l10n-id="editor_free_text_color">Color</label>
<label for="editorFreeTextColor" class="editorParamsLabel" data-l10n-id="editor_text_color">Color</label>
<input type="color" id="editorFreeTextColor" class="editorParamsColor" tabindex="100">
</div>
<div class="editorParamsSetter">
<label for="editorFreeTextFontSize" class="editorParamsLabel" data-l10n-id="editor_free_text_size">Size</label>
<label for="editorFreeTextFontSize" class="editorParamsLabel" data-l10n-id="editor_text_size">Size</label>
<input type="range" id="editorFreeTextFontSize" class="editorParamsSlider" value="10" min="5" max="100" step="1" tabindex="101">
</div>
</div>
Expand All @@ -164,15 +164,15 @@
<div class="editorParamsToolbar hidden doorHangerRight" id="editorInkParamsToolbar">
<div class="editorParamsToolbarContainer">
<div class="editorParamsSetter">
<label for="editorInkColor" class="editorParamsLabel" data-l10n-id="editor_ink_color">Color</label>
<label for="editorInkColor" class="editorParamsLabel" data-l10n-id="editor_draw_color">Color</label>
<input type="color" id="editorInkColor" class="editorParamsColor" tabindex="102">
</div>
<div class="editorParamsSetter">
<label for="editorInkThickness" class="editorParamsLabel" data-l10n-id="editor_ink_thickness">Thickness</label>
<label for="editorInkThickness" class="editorParamsLabel" data-l10n-id="editor_draw_thickness">Thickness</label>
<input type="range" id="editorInkThickness" class="editorParamsSlider" value="1" min="1" max="20" step="1" tabindex="103">
</div>
<div class="editorParamsSetter">
<label for="editorInkOpacity" class="editorParamsLabel" data-l10n-id="editor_ink_opacity">Opacity</label>
<label for="editorInkOpacity" class="editorParamsLabel" data-l10n-id="editor_draw_opacity">Opacity</label>
<input type="range" id="editorInkOpacity" class="editorParamsSlider" value="100" min="1" max="100" step="1" tabindex="104">
</div>
</div>
Expand Down Expand Up @@ -318,11 +318,11 @@
<div class="verticalToolbarSeparator hiddenSmallView"></div>

<div id="editorModeButtons" class="splitToolbarButton toggled hidden" role="radiogroup">
<button id="editorFreeText" class="toolbarButton" disabled="disabled" title="Add FreeText Annotation" role="radio" aria-checked="false" tabindex="36" data-l10n-id="editor_free_text">
<span data-l10n-id="editor_free_text_label">FreeText Annotation</span>
<button id="editorFreeText" class="toolbarButton" disabled="disabled" title="Text" role="radio" aria-checked="false" tabindex="36" data-l10n-id="editor_text">
<span data-l10n-id="editor_text_label">Text</span>
</button>
<button id="editorInk" class="toolbarButton" disabled="disabled" title="Add Ink Annotation" role="radio" aria-checked="false" tabindex="37" data-l10n-id="editor_ink">
<span data-l10n-id="editor_ink_label">Ink Annotation</span>
<button id="editorInk" class="toolbarButton" disabled="disabled" title="Draw" role="radio" aria-checked="false" tabindex="37" data-l10n-id="editor_draw">
<span data-l10n-id="editor_draw_label">Draw</span>
</button>
</div>

Expand Down

0 comments on commit 4ff7d91

Please sign in to comment.