Update CODEOWNERS per the new addon shared strings #10240

mcleinman · 2025-01-31T18:54:13Z

Description

Strings should no longer be in the manifest files, but will be in the shared strings file - let's make sure that @flodolo reveiws those.

My code follows the style guidelines for this project
I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
I have performed a self review of my own code
I have commented my code PARTICULARLY in hard to understand areas
I have added thorough tests where needed

update to shared strings

70d8592

mcleinman requested review from flodolo and lesleyjanenorton January 31, 2025 18:54

mcleinman mentioned this pull request Jan 31, 2025

Remove staging condition from extension promo addon #10239

Merged

5 tasks

mcleinman changed the title ~~Update CODEOWNERS per shared strings~~ Update CODEOWNERS per the new addon shared strings Jan 31, 2025

flodolo approved these changes Jan 31, 2025

View reviewed changes

lesleyjanenorton approved these changes Feb 3, 2025

View reviewed changes

mcleinman merged commit 1dc3271 into main Feb 3, 2025
117 checks passed

mcleinman deleted the update_code_owners branch February 3, 2025 22:22