Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove staging condition from extension promo addon #10239

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

mcleinman
Copy link
Collaborator

@mcleinman mcleinman commented Jan 31, 2025

Description

Get ready for this to go to prod.

Reference

VPN-6837

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested a review from flodolo as a code owner January 31, 2025 18:32
@mcleinman mcleinman removed the request for review from flodolo January 31, 2025 18:33
@mcleinman
Copy link
Collaborator Author

Don't know why @flodolo was auto-added as a reviewer; I removed you, sorry about that.

@flodolo
Copy link
Collaborator

flodolo commented Jan 31, 2025

Don't know why @flodolo was auto-added as a reviewer; I removed you, sorry about that.

It's this
https://github.com/mozilla-mobile/mozilla-vpn-client/blob/main/CODEOWNERS#L1

Not sure if we could remove it now that we're using shared strings…

@mcleinman
Copy link
Collaborator Author

Don't know why @flodolo was auto-added as a reviewer; I removed you, sorry about that.

It's this https://github.com/mozilla-mobile/mozilla-vpn-client/blob/main/CODEOWNERS#L1

Not sure if we could remove it now that we're using shared strings…

PR is up to stop bugging you on these, and instead focus on the translations: #10240

@mcleinman mcleinman merged commit 0dfdf15 into main Jan 31, 2025
125 checks passed
@mcleinman mcleinman deleted the remove-staging-condition-for-extension-addon branch January 31, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants