This repository has been archived by the owner on May 4, 2024. It is now read-only.
sui-move: [7/x][move-package/lock] Move addr_subst and digest to dependency edge #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial design of `DependencyGraph` only allowed for one `addr_subst` and `digest` per package in the transitive dependency graph, but in actuality there can be as many of these as there are dependency edges to that package: - Different `addr_subst` for different packages `P`, `Q` depending on `R` allows the same address in `R` to appear as different addresses in `P` and `Q`. - If `R` is a dependency of `P` and a dev-dependency of `Q`, then its source digest may differ between the two. Fixed by moving the `subst` and `digest` to be edge labels in the graph, rather than node labels. Note that this also changes the lock file format in the following ways: - A package's dependencies are now no longer just the name of the dependency, but an inline table containing the name and optionally the digest and address substitution. - The key within the `move` table that contains all the transitive dependencies is now called `package` rather than `dependency` (this was mainly driven by the naming within the schema, which required a name for the new, richer format for a package's dependencies.) Test Plan: ``` move/language/tools/move-cli$ cargo nextest move/language/tools/move-package$ cargo nextest ```
amnn
requested review from
awelc,
damirka,
dariorussi,
sblackshear and
tnowacki
as code owners
This was referenced Jan 31, 2023
tzakian
approved these changes
Feb 1, 2023
dariorussi
approved these changes
Feb 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial design of
DependencyGraphonly allowed for oneaddr_substanddigestper package in the transitive dependency graph, but in actuality there can be as many of these as there are dependency edges to that package:addr_substfor different packagesP,Qdepending onRallows the same address inRto appear as different addresses inPandQ.Ris a dependency ofPand a dev-dependency ofQ, then its source digest may differ between the two.Fixed by moving the
substanddigestto be edge labels in the graph, rather than node labels.Note that this also changes the lock file format in the following ways:
movetable that contains all the transitive dependencies is now calledpackagerather thandependency(this was mainly driven by the naming within the schema, which required a name for the new, richer format for a package's dependencies.)Test Plan
Stack
See also: #765 for main.