This repository has been archived by the owner on May 4, 2024. It is now read-only.
[4/x][move-package/lock] Fix error message from parse_package_manifest #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2022
amnn
force-pushed
the
lock-4-package-manifest
branch
from
be192f9 to
f601575
Compare
amnn
force-pushed
the
lock-4-package-manifest
branch
from
1cb365b to
cd5b44b
Compare
This was referenced Jan 2, 2023
vgao1996
approved these changes
Jan 18, 2023
Fix the order in which the directory and `Move.toml` are joined together (should be directory and then `Move.toml`, not the other way around as it previously was), and don't drop the context of the underlying error. Also restructuring the function slightly to be less deeply nested, by using `?`. Test Plan: ``` move/language/tools/move-package$ cargo nextest ```
amnn
force-pushed
the
lock-4-package-manifest
branch
from
cd5b44b to
19af3ff
Compare
This was referenced Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the order in which the directory and
Move.tomlare joined together (should be directory and thenMove.toml, not the other way around as it previously was), and don't drop the context of the underlying error.Also restructuring the function slightly to be less deeply nested, by using
?.Test Plan
Stack