This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Proper Unsubscribe handling, fixes #405 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -252,6 +260,23 @@ RedisPersistence.prototype.storeSubscriptions = function(client, cb) { | |||
| }); | |||
|
|
|||
| var op = this._client.multi() | |||
| .get(clientSubKey, function(err, currentSubs){ | |||
There was a problem hiding this comment.
I'd have preferred to write this with Promises, to merge two publishes, however it won't happen in a single multi, since we need first to get current subscriptions before updating them
|
This is happening for redis persistence, I've not tested mongo & level up ones, to check if this bug also applies to them or not :) |
|
I would suggest that you add a unit test in https://github.com/mcollina/mosca/blob/master/test/persistence/abstract.js. So we can verify if this bug happens everywhere or not. |
mcollina
added a commit
that referenced
this pull request
Feb 22, 2016
Proper Unsubscribe handling, fixes #405
|
Merging and releasing. But I would like to have a proper unit test to cover this. |
|
Currently using this in my own fork, tested. But I'll write a containing unit test 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newSubsignature to standard node.js callback style (callback last always)