Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Packet is being stored offline after unsubscribe [redis-persistence] #405

Closed
behrad opened this issue Jan 29, 2016 · 1 comment
Closed

Comments

@behrad
Copy link
Contributor

behrad commented Jan 29, 2016

After unsubscribing a topic, subsequent messages are stored offline and will reach the client after they reconnect. However if you restart mosca after unsubscribe, that won't happen.

My previous fix of persistingClient after unsubscribe should have also contained updating internal in memory _subMatcher in redis persistence so that messages don't get stored as offline. [see https://github.com/mcollina/mosca/blob/master/lib/persistence/redis.js#L329]

I'm going to create a PR to fix this.

@mcollina
Copy link
Collaborator

Thanks! 👍

mcollina added a commit that referenced this issue Feb 22, 2016
Proper Unsubscribe handling, fixes #405
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants