Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Make sure 'nextId' always fits in a uint8. (#304) #305

Merged
merged 1 commit into from Jul 17, 2015
Merged

Make sure 'nextId' always fits in a uint8. (#304) #305

merged 1 commit into from Jul 17, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2015

This fixes #304. I've chosen to use 0 as the first value for nextId as it keeps things simpler and (at least for me) is more intuitive.

mcollina added a commit that referenced this pull request Jul 17, 2015
Make sure 'nextId' always fits in a uint8. (#304)
@mcollina mcollina merged commit 4bc2682 into moscajs:master Jul 17, 2015
@mcollina
Copy link
Collaborator

Thanks so much!

@ghost ghost deleted the fixes-304 branch July 17, 2015 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Value is out of bounds" in mqtt-packet/generate.js
1 participant