Merge pull request #305 from bmcustodio/fixes-304

Make sure 'nextId' always fits in a uint8. (#304)
moscajs · Jul 17, 2015 · 4bc2682 · 4bc2682
2 parents 1315d4c + 0be6860
commit 4bc2682
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/client.js b/lib/client.js
@@ -42,7 +42,7 @@ function Client(conn, server) {
   this.logger = server.logger;
   this.subscriptions = {};
 
-  this.nextId = 1;
+  this.nextId = 0;
   this.inflight = {};
   this.inflightCounter = 0;
   this._lastDedupId = -1;
@@ -214,6 +214,9 @@ Client.prototype._buildForward = function() {
         forward = true,
         newId = this.nextId++;
 
+    // Make sure 'nextId' always fits in a uint8 (http://git.io/vmgKI).
+    this.nextId %= 65536;
+
     var packet = {
       topic: topic,
       payload: payload,