feat: Add support for using DEV/QA for mongodbgov #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maastha
changed the title
maastha
changed the title
lantoli
approved these changes
Mar 11, 2024
|
LGTM, one question asked offline |
|
@lantoli updated based on discussion |
lantoli
reviewed
Mar 12, 2024
lantoli
approved these changes
Mar 12, 2024
Co-authored-by: Leo Antoli <[email protected]>
AgustinBettati
approved these changes
Mar 12, 2024
Comment on lines
+492
to
+494
| func isGovBaseURLConfiguredForProvider(data *tfMongodbAtlasProviderModel) bool { | ||
| return isGovBaseURLConfigured(data.BaseURL.ValueString()) | ||
| } |
There was a problem hiding this comment.
nit: would remove this function replacing for the inner call directly
Comment on lines
+580
to
+582
| func isGovBaseURLConfiguredForSDK2Provider(d *schema.ResourceData) bool { | ||
| return isGovBaseURLConfigured(d.Get("base_url").(string)) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if
is_mongodbgov_cloudflag is set in the provider config, it will always call mongodbgov production, even ifbase_urlis set to use dev/QA env of mongodbgov. This PR will let the user/developer specify base_url correctly whenis_mongodbgov_cloudflag is set.Link to any related issue(s):
Type of change:
Required Checklist:
Further comments