feat: Add support for using DEV/QA for mongodbgov (#2009)

Author: maastha

internal/provider/provider.go

@@ -34,14 +34,15 @@ import (
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streamconnection"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streaminstance"
-
 	"github.com/mongodb/terraform-provider-mongodbatlas/version"
 )
 
 const (
-	MongodbGovCloudURL   = "https://cloud.mongodbgov.com"
-	ProviderConfigError  = "error in configuring the provider."
-	MissingAuthAttrError = "either Atlas Programmatic API Keys or AWS Secrets Manager attributes must be set"
+	MongodbGovCloudURL    = "https://cloud.mongodbgov.com"
+	MongodbGovCloudQAURL  = "https://cloud-qa.mongodbgov.com"
+	MongodbGovCloudDevURL = "https://cloud-dev.mongodbgov.com"
+	ProviderConfigError   = "error in configuring the provider."
+	MissingAuthAttrError  = "either Atlas Programmatic API Keys or AWS Secrets Manager attributes must be set"
 )
 
 type MongodbtlasProvider struct{}
@@ -296,7 +297,9 @@ func parseTfModel(ctx context.Context, tfAssumeRoleModel *tfAssumeRoleModel) *co
 
 func setDefaultValuesWithValidations(ctx context.Context, data *tfMongodbAtlasProviderModel, resp *provider.ConfigureResponse) tfMongodbAtlasProviderModel {
 	if mongodbgovCloud := data.IsMongodbGovCloud.ValueBool(); mongodbgovCloud {
-		data.BaseURL = types.StringValue(MongodbGovCloudURL)
+		if !isGovBaseURLConfiguredForProvider(data) {
+			data.BaseURL = types.StringValue(MongodbGovCloudURL)
+		}
 	}
 	if data.BaseURL.ValueString() == "" {
 		data.BaseURL = types.StringValue(MultiEnvDefaultFunc([]string{
@@ -475,3 +478,17 @@ func MultiEnvDefaultFunc(ks []string, def any) any {
 	}
 	return def
 }
+
+func isGovBaseURLConfigured(baseURL string) bool {
+	if baseURL == "" {
+		baseURL = MultiEnvDefaultFunc([]string{
+			"MONGODB_ATLAS_BASE_URL",
+			"MCLI_OPS_MANAGER_URL",
+		}, "").(string)
+	}
+	return baseURL == MongodbGovCloudDevURL || baseURL == MongodbGovCloudQAURL
+}
+
+func isGovBaseURLConfiguredForProvider(data *tfMongodbAtlasProviderModel) bool {
+	return isGovBaseURLConfigured(data.BaseURL.ValueString())
+}

internal/provider/provider_sdk2.go

@@ -11,6 +11,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
+
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey"
@@ -324,8 +325,10 @@ func setDefaultsAndValidations(d *schema.ResourceData) diag.Diagnostics {
 
 	mongodbgovCloud := conversion.Pointer(d.Get("is_mongodbgov_cloud").(bool))
 	if *mongodbgovCloud {
-		if err := d.Set("base_url", MongodbGovCloudURL); err != nil {
-			return append(diagnostics, diag.FromErr(err)...)
+		if !isGovBaseURLConfiguredForSDK2Provider(d) {
+			if err := d.Set("base_url", MongodbGovCloudURL); err != nil {
+				return append(diagnostics, diag.FromErr(err)...)
+			}
 		}
 	}
 
@@ -573,3 +576,7 @@ func expandAssumeRole(tfMap map[string]any) *config.AssumeRole {
 
 	return &assumeRole
 }
+
+func isGovBaseURLConfiguredForSDK2Provider(d *schema.ResourceData) bool {
+	return isGovBaseURLConfigured(d.Get("base_url").(string))
+}