Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User/bgr/ideal hurricane config #860

Merged
merged 9 commits into from
Oct 22, 2018
Merged

User/bgr/ideal hurricane config #860

merged 9 commits into from
Oct 22, 2018

Conversation

breichl
Copy link
Collaborator

@breichl breichl commented Oct 17, 2018

Updates to idealized_hurricane forcing case for 3D test case.

  • This P/R is in conjunction with P/R User/bgr/ideal hurricane NOAA-GFDL/MOM6-examples#251
  • Removes the init TS from the idealized_hurricane forcing case set-up (it was redundant with the CVMix_tests TS init).
  • Adds improved capabilities to src/user/Idealized_Hurricane.F90 to map 3d wind for forcing MOM6 in idealized domain (keeps the old legacy routine as an option to preserve test case answers, this should be removed and the updated code should be kept).
  • Renames "SCM_idealized_hurricane" to "idealized_hurricane" in module and control structure.
  • Adds WAVES container pass through split RK2 dynamics (was previously only passed if using unsplit dynamics).
  • Additional outputs and corrections to use of WAVE container (Stokes drift) data in KPP for Langmuir turbulence parameterization and some modification to implementation of said parameterizations (clean-up of Langmuir number calculation and use).
  • Fixes Stokes drift allocation bug in MOM_wave_interface where the variables were not allocated prior to use.

brandon.reichl added 8 commits August 16, 2018 20:03
Updates to idealized hurricane routine for non-SCM (full domain) simu…
bb7612a 
…lations

- Changed names of module and subroutine to remove "SCM"
- Changed name of SCM ideal hurricane state initializations
- Major modifications to user/SCM_ideal_hurricane file
Merge branch 'dev/gfdl' into user/bgr/ideal_hurricane_config
bb8fa4a
Numerous modifications to improve Ideal hurricane config and wave fun…
6ef7d1d 
…ctionality in such cases.

 - wave parameters passed to split dynamics for down-Stokes gradient momentum mixing.
 - KPP updates to compute SL and turbulent Langmuir number for paramaterization options.
 - KPP bug-fixes to pass waves to correct routines for their use.
 - wave_interface bug-fix so Stokes drift bands are properly initialized.
Merge branch 'dev/gfdl' into user/bgr/ideal_hurricane_config
71a348c
Updates to use the new idealized_hurricane test case.
8e29a1b 
 - The new and old (SCM) idealized_hurricane test case capabilies are included.
 - This includes a redundant subroutine SCM_idealized_hurricane_wind_forcing, which has capabilities replaced by the new idealized_hurricane_wind_forcing, but will change model answers.  When an answer change is deemed acceptable this code should be removed and a new test case should be made from the new (improved) code.
Renaming SCM_idealized_hurricane.F90 to Idealized_Hurricane.F90
05359f0
Updates to idealized hurricane code style.
654485e
Merge branch 'dev/gfdl' into user/bgr/ideal_hurricane_config
e48da04
@breichl breichl mentioned this pull request Oct 17, 2018
Merged
@Hallberg-NOAA Hallberg-NOAA merged commit 009d00b into mom-ocean:dev/gfdl Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breichl @Hallberg-NOAA