-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/bgr/ideal hurricane #251
Merged
Hallberg-NOAA
merged 10 commits into
NOAA-GFDL:dev/gfdl
from
breichl:user/bgr/ideal_hurricane
Oct 22, 2018
Merged
User/bgr/ideal hurricane #251
Hallberg-NOAA
merged 10 commits into
NOAA-GFDL:dev/gfdl
from
breichl:user/bgr/ideal_hurricane
Oct 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A 3d implementation of the SCM_ideal_hurricane case - Work to be done for choosing resolution/parameterizations/etc in MOM_input
- Previously the MOM_input files used the ideal_hurr TS initialization class. This class is removed in a subsequent PR to MOM6, since it is redundant and has less features than the CVMix TS initialization class. So in preperation, this P/R changes the MOM_input to use the CVMix TS class, which does not change answers since it had the same capabilities..
- The ideal_hurricane case no longer supports a TS class, since its functionality was moved to SCM_CVMix. Therefore, the SCM_idealized_hurricane test case is updated to use the CVMix TS initilazation. Additionally, the MOM_parameter_doc.all and MOM_parameter_doc.short for both the SCM_idealized_hurricane case and the CVmix_SCM_tests cases were updated to reflect the new code.
- MOM_input changed for a .1 day simulation for the test case. - MOM_parameter files added - .nc file added from .cdl file for vertical grid. - ideal_hurr TS class changed to CVMix TS class for a corresponding PR to MOM6. - This test-case also relies on a corresponding PR to MOM6
…s in dev/gfdl). - dtdz was updated in MOM_override to be 0 in dev/gfdl, this commit is fixed to reflect that using the new scm TS init routine.
- Changing the name of a directory with ~100 subdirectories as part of a larger P/R made the resulting code/answers difficult to verify for consistency. - Reverting to name CVmix_SCM_tests to streamline the original P/R. - The renaming of the directory can be redone in its own commit and P/R with no other changes (if desired).
Thanks for this PR, @breichl. However changing the directory name from CVmix_SCM_tests folder to CVMix_SCM_tests is disrupting our testing of this and the other changes. If there is any way that you could revert that specific change so that we can separately accept the code changes, that would be helpful for the testing process. |
mom6bot
added a commit
to mom6bot/MOM6-examples
that referenced
this pull request
Oct 25, 2023
- NOAA-GFDL/MOM6@c9fc30d61 ice shelf dHdt and optimization - NOAA-GFDL/MOM6@3d07e5beb Comment omega_w2x entries in nuopc_cap - NOAA-GFDL/MOM6@3720b9920 Comment all omega_w2x entries - NOAA-GFDL/MOM6@e2bbb08dc Set fpmix to false by default - NOAA-GFDL/MOM6@5e6e6576f remove fms_io_mod import - NOAA-GFDL/MOM6@de55fd6d2 fix multiinstance log filename correction and remove FMS1 io api calls. - NOAA-GFDL/MOM6@d363034fc Deprecate mct cap (NOAA-GFDL#257) - NOAA-GFDL/MOM6@5bc0c5e07 Pass wavebands from coupler to wave_parameters_CS (NOAA-GFDL#255) - NOAA-GFDL/MOM6@be40a4136 add run time info (NOAA-GFDL#114) - NOAA-GFDL/MOM6@d9aa751a4 Revert order of variables in vertFPmix - NOAA-GFDL/MOM6@66fd876af Removed L_diag and moved variables in vertFPmix - NOAA-GFDL/MOM6@7b7052e9b Describe local variables and make code consistent - NOAA-GFDL/MOM6@d4aa10857 Add Leith+E (NOAA-GFDL#251) - NOAA-GFDL/MOM6@c57789f41 Rearrange do-loops and if statements - NOAA-GFDL/MOM6@2f34d6521 Merge latest mom-ocean main (NOAA-GFDL#254) - NOAA-GFDL/MOM6@8ec0de7b0 Merge remote-tracking branch 'MAIN/main' into feature/update-to-main-20230811 - NOAA-GFDL/MOM6@27518f750 Make neutral diffusion work with 3D diffusivities - NOAA-GFDL/MOM6@a58803372 Make HBD work with 3D diffusivities - NOAA-GFDL/MOM6@36c1e266b Make tracer diffusivities 3D - NOAA-GFDL/MOM6@cf29f1beb Allocate hbl - NOAA-GFDL/MOM6@53ccbc329 Fix line length - NOAA-GFDL/MOM6@8234e696d Add hbd to the control structure - NOAA-GFDL/MOM6@b4bd22322 Output relevant fields when diff or visc < 0 - NOAA-GFDL/MOM6@61baca8ea Option to taper neutral diffusion - NOAA-GFDL/MOM6@8812ba999 Merge remote-tracking branch 'gustavo/fpmix_draft_17may2022' into fpmix_draft_18April2023 - NOAA-GFDL/MOM6@32b969ef4 Accommodate multi-instance runs in CESM (NOAA-GFDL#241) - NOAA-GFDL/MOM6@ebf11d7c7 migrate nearly all refs to CFC_cap into MOM_tracer_flow_control and MOM_CFC_cap - NOAA-GFDL/MOM6@a697159a2 Obsolete the USE_LATERAL_BOUNDARY_DIFFUSION option - NOAA-GFDL/MOM6@eff5036e0 Unit tests and final cleaning - NOAA-GFDL/MOM6@b85581ea8 read atm CFC hemispheric aveages from CFC_BC_FILE, instead of 2D fields - NOAA-GFDL/MOM6@db06a5494 add CFC_BC_year_offset, converts model time to time in CFC_BC_file - NOAA-GFDL/MOM6@c2a30839c Improve performance of hor_bnd_diffusion - NOAA-GFDL/MOM6@f666a67cb Rename module to hor_bnd_diffusion - NOAA-GFDL/MOM6@9b4bd84b5 Add mssing call to get_param for FPMIX - NOAA-GFDL/MOM6@864506e85 Add omega_w2x to fluxes and forces - NOAA-GFDL/MOM6@7624a83b8 Add missing use for vertFPmix - NOAA-GFDL/MOM6@143d11752 Updates to vertFPmix - NOAA-GFDL/MOM6@cb65bdcef Change name of logical - NOAA-GFDL/MOM6@9c103f1f9 First draft for fpmix - NOAA-GFDL/MOM6@b7390f7e0 Makes set_u_at_v and set_v_at_u public
marshallward
pushed a commit
that referenced
this pull request
Oct 25, 2023
- NOAA-GFDL/MOM6@c9fc30d61 ice shelf dHdt and optimization - NOAA-GFDL/MOM6@3d07e5beb Comment omega_w2x entries in nuopc_cap - NOAA-GFDL/MOM6@3720b9920 Comment all omega_w2x entries - NOAA-GFDL/MOM6@e2bbb08dc Set fpmix to false by default - NOAA-GFDL/MOM6@5e6e6576f remove fms_io_mod import - NOAA-GFDL/MOM6@de55fd6d2 fix multiinstance log filename correction and remove FMS1 io api calls. - NOAA-GFDL/MOM6@d363034fc Deprecate mct cap (#257) - NOAA-GFDL/MOM6@5bc0c5e07 Pass wavebands from coupler to wave_parameters_CS (#255) - NOAA-GFDL/MOM6@be40a4136 add run time info (#114) - NOAA-GFDL/MOM6@d9aa751a4 Revert order of variables in vertFPmix - NOAA-GFDL/MOM6@66fd876af Removed L_diag and moved variables in vertFPmix - NOAA-GFDL/MOM6@7b7052e9b Describe local variables and make code consistent - NOAA-GFDL/MOM6@d4aa10857 Add Leith+E (#251) - NOAA-GFDL/MOM6@c57789f41 Rearrange do-loops and if statements - NOAA-GFDL/MOM6@2f34d6521 Merge latest mom-ocean main (#254) - NOAA-GFDL/MOM6@8ec0de7b0 Merge remote-tracking branch 'MAIN/main' into feature/update-to-main-20230811 - NOAA-GFDL/MOM6@27518f750 Make neutral diffusion work with 3D diffusivities - NOAA-GFDL/MOM6@a58803372 Make HBD work with 3D diffusivities - NOAA-GFDL/MOM6@36c1e266b Make tracer diffusivities 3D - NOAA-GFDL/MOM6@cf29f1beb Allocate hbl - NOAA-GFDL/MOM6@53ccbc329 Fix line length - NOAA-GFDL/MOM6@8234e696d Add hbd to the control structure - NOAA-GFDL/MOM6@b4bd22322 Output relevant fields when diff or visc < 0 - NOAA-GFDL/MOM6@61baca8ea Option to taper neutral diffusion - NOAA-GFDL/MOM6@8812ba999 Merge remote-tracking branch 'gustavo/fpmix_draft_17may2022' into fpmix_draft_18April2023 - NOAA-GFDL/MOM6@32b969ef4 Accommodate multi-instance runs in CESM (#241) - NOAA-GFDL/MOM6@ebf11d7c7 migrate nearly all refs to CFC_cap into MOM_tracer_flow_control and MOM_CFC_cap - NOAA-GFDL/MOM6@a697159a2 Obsolete the USE_LATERAL_BOUNDARY_DIFFUSION option - NOAA-GFDL/MOM6@eff5036e0 Unit tests and final cleaning - NOAA-GFDL/MOM6@b85581ea8 read atm CFC hemispheric aveages from CFC_BC_FILE, instead of 2D fields - NOAA-GFDL/MOM6@db06a5494 add CFC_BC_year_offset, converts model time to time in CFC_BC_file - NOAA-GFDL/MOM6@c2a30839c Improve performance of hor_bnd_diffusion - NOAA-GFDL/MOM6@f666a67cb Rename module to hor_bnd_diffusion - NOAA-GFDL/MOM6@9b4bd84b5 Add mssing call to get_param for FPMIX - NOAA-GFDL/MOM6@864506e85 Add omega_w2x to fluxes and forces - NOAA-GFDL/MOM6@7624a83b8 Add missing use for vertFPmix - NOAA-GFDL/MOM6@143d11752 Updates to vertFPmix - NOAA-GFDL/MOM6@cb65bdcef Change name of logical - NOAA-GFDL/MOM6@9c103f1f9 First draft for fpmix - NOAA-GFDL/MOM6@b7390f7e0 Makes set_u_at_v and set_v_at_u public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idealized_hurricane test case to ocean_only.