Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for https://github.com/mojaloop/project/issues/933 #12

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Aug 16, 2019

Fix for mojaloop/project#933:

  • Commented out getParticipant from DB Cache with appropriate comment.
  • Updated dependencies to latest versions
  • Bumped version

- Commented out getParticipant from DB Cache with appropriate comment.
- Updated dependencies to latest versions
- Bumped version
@mdebarros mdebarros self-assigned this Aug 16, 2019
@mdebarros mdebarros added the bug Something isn't working label Aug 16, 2019
@mdebarros mdebarros requested review from ndonnan and oderayi August 16, 2019 11:13
elnyry-sam-k
elnyry-sam-k previously approved these changes Aug 16, 2019
vgenev
vgenev previously approved these changes Aug 16, 2019
Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rmothilal
rmothilal previously approved these changes Aug 16, 2019
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy

@mdebarros mdebarros dismissed stale reviews from rmothilal, vgenev, and elnyry-sam-k via 12e28a9 August 16, 2019 11:15
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy

Copy link
Contributor

@oderayi oderayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants