Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes issue with checking active / inactive status of a participant #933

Closed
2 tasks done
elnyry-sam-k opened this issue Aug 16, 2019 · 1 comment
Closed
2 tasks done

Quotes issue with checking active / inactive status of a participant #933

elnyry-sam-k opened this issue Aug 16, 2019 · 1 comment
Assignees
@elnyry-sam-k @mdebarros @rmothilal
Milestone
Sprint 7.3

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Aug 16, 2019 •
edited
Loading

Summary:
The Quotes service seems to have an issue with checking active / inactive status of a participant. This is causing the quotes to pass-through some times when participant is inactive and vice-versa.

Severity:
Medium

Priority:
Medium

Expected Behavior

  1. Quotes service should fail with a error code that participant wasn't found (2001) when a participant is Inactive. (Likewise when its active, the quotes POST requests should go through without issue)

Steps to Reproduce

  1. On a given Mojaloop deployment, de-activate a participant and re-activate it. After de-activating it, run a POST /quotes request and its not getting de-activated.

Specifications

  • Component (if known): central services
  • Version: v7.3.1-snapshot
  • Platform: AWS
  • Subsystem: quoting-service
  • Type of testing: Functional, regression
  • Bug found/raised by: @elnyry @mdebarros

PRs:

Notes:

  • Severity when opened:
  • Priority when opened:
@elnyry-sam-k elnyry-sam-k added this to the Sprint 7.3 milestone Aug 16, 2019
mdebarros added a commit to mdebarros/quoting-service that referenced this issue Aug 16, 2019
@mdebarros
Fixes for mojaloop/project#933
8747732 
- Commented out getParticipant from DB Cache with appropriate comment.
- Updated dependencies to latest versions
- Bumped version
@mdebarros mdebarros mentioned this issue Aug 16, 2019
Merged
@mdebarros
Copy link
Member

mdebarros commented Aug 16, 2019 •
edited
Loading

PR for fix: mojaloop/quoting-service#12

The issue was that Quoting-Service implemented a cache layer over the DB for most "GET" or query operations. I commented out the getParticipant operation and added an appropriate comment.

mdebarros added a commit to mojaloop/quoting-service that referenced this issue Aug 16, 2019
@mdebarros
Fixes for mojaloop/project#933 (#12)
2bbb41e 
* Fixes for mojaloop/project#933
- Commented out getParticipant from DB Cache with appropriate comment.
- Updated dependencies to latest versions
- Bumped version
@mdebarros mdebarros mentioned this issue Aug 16, 2019
Closed
@rmothilal rmothilal mentioned this issue Aug 20, 2019
Merged
rmothilal added a commit to mojaloop/quoting-service that referenced this issue Aug 20, 2019
@rmothilal
Hotfix/participants getting cached (#17)
28aa00b 
Fix for mojaloop/project#933
Added participant check to quote post
Updated dependencies
@elnyry-sam-k elnyry-sam-k mentioned this issue Aug 22, 2019
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elnyry-sam-k elnyry-sam-k

@mdebarros mdebarros

@rmothilal rmothilal

Labels
None yet
Projects
None yet
Milestone
Sprint 7.3
Development

No branches or pull requests
3 participants
@elnyry-sam-k @mdebarros @rmothilal