Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance SDK Scheme Adaptor to support the request to Pay use case #3344

Open
8 of 19 tasks
PaulGregoryBaker opened this issue May 16, 2023 · 2 comments
Open
8 of 19 tasks

Enhance SDK Scheme Adaptor to support the request to Pay use case #3344

PaulGregoryBaker opened this issue May 16, 2023 · 2 comments
Labels
core-dev-squad epic oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it pi-22

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented May 16, 2023 •
edited
Loading

Goal:

As a DFSP using SDK scheme adaptor to connect to Mojaloop
I want to have the SDK supporting request to pay
so that use the request to pay use case

Acceptance Criteria:

  • Verify that we have an sequence diagram defined that specifies the SDK calls and Mojaloop calls that support the request to pay use case
  • Fully support the FSPIOP request to pay use case
    • Verify that OTP authentication is supported
    • Verify that direct Payer acceptance is supported
    • Verify that the on rejection use case is supported.
  • Verify that there is support for homeRTPTransactionId on both the Payer DFSP and the Payee DFSP
  • Verify that the transactionRequestId is standardised through the SDK adapter in the RTP flows.
  • Verify that the SDK documentation is update to describe this use case (both local repo and official docs).
  • Verify that the Payer's detail can be validated by the Payee (I.e. AUTOACCEPTPARTY = false)
  • Verify that the SDK functional tests tests the above use case

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating

Tasks:

  • TBD [ @? ]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added core-dev-squad epic pi-21 Issues prioritized for Program Increment 21 labels May 16, 2023
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label May 22, 2023
@mdebarros
Copy link
Member

mdebarros commented May 23, 2023 •
edited
Loading

requestToPaySDK drawio

☝️ the above diagram has drawio information imbedded.

@mdebarros
Copy link
Member

Working Branches:

@mdebarros mdebarros mentioned this issue May 23, 2023
Merged
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 6, 2023
@mdebarros
feat(mojaloop/3344): enhance SDK Scheme Adaptor to support the reques…
3af06ce 
…t to Pay use case (#446)

feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344
- feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345
- feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347

---------

Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Vijay <[email protected]>

---------

BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 6, 2023
@mdebarros @vijayg10
feat(mojaloop/3344)!: enhance SDK Scheme Adaptor to support the reque…
388f1df 
…st to Pay use case (#446)

feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344
- feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345
- feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347

fix: updates for nx v16 changes (#449)
- updated main nx.json config affected branch to `master`
- removed deprecated `--all` from all `nx affected` NPM scripts

BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.

---------

Co-authored-by: vijayg10 <[email protected]>
Co-authored-by: Vijay <[email protected]>
@chris-me-law chris-me-law added pi-22 and removed pi-21 Issues prioritized for Program Increment 21 labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core-dev-squad epic oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it pi-22
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elnyry-sam-k @mdebarros @PaulGregoryBaker @chris-me-law