feat: SDK support for request-to-pay documented #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulGregoryBaker
requested review from
millerabel,
mdebarros,
kjw000,
elnyry-sam-k,
lewisdaly and
simeonoriko
as code owners
mdebarros
added a commit
to mojaloop/sdk-scheme-adapter
that referenced
this pull request
Jun 6, 2023
…t to Pay use case (#446) feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344 - feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345 - feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347 --------- Co-authored-by: vijayg10 <[email protected]> Co-authored-by: Vijay <[email protected]> --------- BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.
mdebarros
added a commit
to mojaloop/sdk-scheme-adapter
that referenced
this pull request
Jun 6, 2023
…st to Pay use case (#446) feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344 - feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345 - feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347 fix: updates for nx v16 changes (#449) - updated main nx.json config affected branch to `master` - removed deprecated `--all` from all `nx affected` NPM scripts BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information. --------- Co-authored-by: vijayg10 <[email protected]> Co-authored-by: Vijay <[email protected]>
mdebarros
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Hey @PaulGregoryBaker ,
PR looks good, just some minor suggestions/tweaks for you to look at.
Let me know your thoughts.
docs/technical/sdk-scheme-adapter/assets/sequence/SDKrequestToPay.plantuml
Outdated
Show resolved
Hide resolved
docs/technical/sdk-scheme-adapter/assets/sequence/SDKrequestToPay.plantuml
Outdated
Show resolved
Hide resolved
docs/technical/sdk-scheme-adapter/assets/sequence/SDKrequestToPay.plantuml
Outdated
Show resolved
Hide resolved
docs/technical/sdk-scheme-adapter/assets/sequence/SDKrequestToPay.plantuml
Show resolved
Hide resolved
docs/technical/sdk-scheme-adapter/assets/sequence/requestToPaySDK-R2P-SequenceDiagram.svg
Outdated
Show resolved
Hide resolved
Co-authored-by: Miguel de Barros <[email protected]>
…Pay.plantuml Co-authored-by: Miguel de Barros <[email protected]>
…Pay.plantuml Co-authored-by: Miguel de Barros <[email protected]>
Co-authored-by: Miguel de Barros <[email protected]>
…Pay.plantuml Co-authored-by: Miguel de Barros <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.