Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nosetests with pytest #85

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

PeterMeisrimelModelon
Copy link
Collaborator

No description provided.

@PeterMeisrimelModelon PeterMeisrimelModelon self-assigned this Feb 12, 2024
Copy link
Member

@modelonrobinandersson modelonrobinandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just minor comments.
Do you have any average numbers on how much time it takes to run the tests with and without these changes?

tests/solvers/test_sundials.py Outdated Show resolved Hide resolved
tests/solvers/test_sundials.py Outdated Show resolved Hide resolved
tests/solvers/test_sundials.py Outdated Show resolved Hide resolved
tests/solvers/test_sundials.py Outdated Show resolved Hide resolved
@PeterMeisrimelModelon
Copy link
Collaborator Author

This looks great, just minor comments. Do you have any average numbers on how much time it takes to run the tests with and without these changes?

Based on the numbers of the last few GitHub actions runs: ~20 sec with pytest to run the tests, ~36 sec on nose with Python 3.11, however also ~20 sec on current master, without any Python changes, with nose.

PeterMeisrimelModelon and others added 2 commits November 8, 2024 16:32
work in progress; more conversion

Cleanup

removing redundant testattr

removing warnings

Resolving DeprecationWarnings in tests

Fixing issue in 1 test; more deprecation issues

Replaced commented-out tests with appropriate pytest.mark.skip

Cleanup; some more minor Deprecations

Review fixes
Cleanup

removed pytest as requirement from examples

Removing tests from the Assimulo installation

Adding pytest config; adjusted instructions

simplified workflow file

Changed if in test to skipif

Added missing reason in skipif
Copy link
Member

@modelonrobinandersson modelonrobinandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

examples/euler_vanderpol.py Show resolved Hide resolved
@PeterMeisrimelModelon PeterMeisrimelModelon merged commit 3b2b79e into master Nov 20, 2024
6 checks passed
@PeterMeisrimelModelon PeterMeisrimelModelon deleted the dev-pm-pytest branch November 20, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants