-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nosetests with pytest #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just minor comments.
Do you have any average numbers on how much time it takes to run the tests with and without these changes?
Based on the numbers of the last few GitHub actions runs: ~20 sec with pytest to run the tests, ~36 sec on nose with Python 3.11, however also ~20 sec on current master, without any Python changes, with nose. |
35b1318
to
9f3b611
Compare
f1296ff
to
086b6db
Compare
7846251
to
15959a4
Compare
work in progress; more conversion Cleanup removing redundant testattr removing warnings Resolving DeprecationWarnings in tests Fixing issue in 1 test; more deprecation issues Replaced commented-out tests with appropriate pytest.mark.skip Cleanup; some more minor Deprecations Review fixes
15959a4
to
df68d4e
Compare
Cleanup removed pytest as requirement from examples Removing tests from the Assimulo installation Adding pytest config; adjusted instructions simplified workflow file Changed if in test to skipif Added missing reason in skipif
1f275a3
to
b40b609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
No description provided.