Unpin scipy upper version limit #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: It works fine with 1.13 and with have no indication that something will break with the next minor versions (and no major version bump in sight)
|
This was not due to any issues in Assimulo directly, but we did detect a regression in PyFMI with scipy 1.13.0. From the initial investigation we could not yet rule out that Assimulo might be affected (or that the root cause is within Assimulo). We have not had the time to dig deeper into this yet. It is not clear what caused the regression based on the scipy changelog alone. |
|
Well tests also pass at pyfmi with scipy 1.13 so the pinning can be dropped at least here |
PeterMeisrimelModelon
merged commit 6560918
into
modelon-community:master
2 checks passed
modelonrobinandersson
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Unpin scipy upper version limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: It works fine with 1.13 and with have no indication that something will break with the next minor versions (and no major version bump in sight)