Add some performance instrumentation to our code #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
approved these changes
Dec 7, 2022
| @@ -490,3 +503,14 @@ where | |||
| serde_json::to_writer(writer, &source).unwrap(); | |||
| } | |||
| } | |||
|
|
|||
| pub fn with_timer<T, F>(func: F, description: &str) -> T | |||
There was a problem hiding this comment.
Please add documentation
| @@ -82,58 +83,66 @@ impl CodegenBackend for GotocCodegenBackend { | |||
| check_options(tcx.sess, need_metadata_module); | |||
| check_crate_items(&gcx); | |||
|
|
|||
| let items = collect_codegen_items(&gcx); | |||
| let items = with_timer(|| collect_codegen_items(&gcx), "reachability analysis"); | |||
There was a problem hiding this comment.
Can we be more specific, e.g. "codegen items reachability analysis"?
There was a problem hiding this comment.
I changed it to be "codegen reachability analysis". Let me know if that's OK.
| @@ -191,6 +203,19 @@ impl KaniSession { | |||
|
|
|||
| Ok(Some(process)) | |||
| } | |||
|
|
|||
| pub fn with_timer<T, F>(&self, func: F, description: &str) -> T | |||
There was a problem hiding this comment.
Might be worth creating a "common" or "utils" crate at some point that includes this function (and similar ones) to avoid duplication.
There was a problem hiding this comment.
I totally agree. Not sure it's worth it in this PR though
celinval
force-pushed
the
issue-xxxx-instrument-perf
branch
from
9ca5528 to
2fcd508
Compare
tedinski
reviewed
Dec 13, 2022
| @@ -117,6 +117,9 @@ impl KaniSession { | |||
|
|
|||
| if self.args.debug { | |||
| flags.push("--log-level=debug".into()); | |||
| } else if self.args.verbose { | |||
| // Print the symtab command being invoked. | |||
| flags.push("--log-level=info".into()); | |||
There was a problem hiding this comment.
This was removed in #1730 is the underlying issue fixed there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
For runs using
--verbose, Kani will now print the time spent in some parts of the code. This include calls to all CProver utilities and a few other places in the compiler.Resolved issues:
N/A
Related RFC:
Call-outs:
Note that the time measured in
run_cbmcincludes parsing the results. This is similar to the "Verification Time" we print, but it can be misleading when we are usingdebugmode, since it can more than double the actual time we report to be the verification time. We should probably improve that, but it's out of the scope of this PR. The overhead is also small when running a release build.Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.