Fix cargo kani --debug and remove debug logs from --verbose
#1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix model-checking#1348: Fix `cargo kani --debug` by redirecting kani-compiler logs to the STDERR so it doesn't conflict with cargo's output expectations. - Fix model-checking#1631: Remove `kani-compiler` logs from the output of `--verbose`.
celinval
changed the title
cargo kani --debug and remove debug logs from --verbose
tedinski
approved these changes
Sep 29, 2022
Comment on lines
-110
to
-111
| } else if self.args.verbose { | ||
| flags.push("--log-level=info".into()); |
There was a problem hiding this comment.
Was this behavior undesirable? Not sure why this was changed.
The stderr logging was enough to fix, right?
There was a problem hiding this comment.
This was to fix #1631
There was a problem hiding this comment.
Hah, despite me being the one to file those issues, I'd forgotten what the verbose one was actually about.
Makes sense! :)
The CI failure is a mystery though...
There was a problem hiding this comment.
I found out the issue. Submitting a patch now.
tedinski
approved these changes
Sep 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
cargo kani --debugby redirecting kani-compiler logs to the STDERR so it doesn't conflict with cargo's output expectations.kani-compilerlogs from the output of--verbose.Resolved issues:
Fix #1631
Fix #1348
Related RFC:
N/A
Call-outs:
These were tiny fixes so I combined them in one PR.
Testing:
How is this change tested? N/A
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.