Add unit test for html reporter #3102

38elements · 2017-11-11T13:09:14Z

Description of the Change

This adds unit test for html reporter.
This is related to #3071 .

coveralls · 2017-11-11T13:15:30Z

Coverage increased (+4.5%) to 94.419% when pulling 0ac9125 on 38elements:html into 1bb6b39 on mochajs:master.

coveralls · 2017-11-11T13:37:01Z

Coverage increased (+4.5%) to 94.419% when pulling 2427383 on 38elements:html into 1bb6b39 on mochajs:master.

coveralls · 2017-11-11T13:56:36Z

Coverage increased (+4.5%) to 94.419% when pulling a23a483 on 38elements:html into 1bb6b39 on mochajs:master.

38elements · 2017-11-13T11:11:18Z

I am sorry.
I did not notice the assignee.

ScottFreeCode · 2017-11-15T07:37:29Z

Actually, I'm sorry I didn't reply to this sooner -- no need to worry that the issue's assigned (that just helps us track who's looking at it) or even that there's already work toward it, we're definitely open to alternative attempts and new contributions! While my preference is to ensure things are tested and coverage collected in all the "real" browsers Mocha supports, I still need to figure out whether that's even going to be doable with the recent upgrades relating to Mocha's test harness for browser usage. So, while I can't guarantee which we'd pick at this point, if you've already coded it up we may as well see how it compares. Would you mind keeping this open for further assessment (or, at least, make sure the fork/branch stays available)? Thanks! (And thanks for taking a shot at adding test for this, in any case!)

38elements · 2017-11-15T11:57:20Z

Hi, @ScottFreeCode.
Thank you for your reply and contribution for mocha.
I reopen this pull request and keep the branch and opening this.

coveralls · 2017-11-15T12:03:20Z

Coverage increased (+4.5%) to 94.419% when pulling a23a483 on 38elements:html into 1bb6b39 on mochajs:master.

boneskull · 2017-12-07T00:11:00Z

a jsdom-based test is better than nothing imo.

boneskull

Thanks for this. I think, however, we just want to make this part of our existing browser tests.

remove jsdom
move the spec file into test/browser-specific/
append the spec path to cfg.files after this line http://github.com/mochajs/mocha/blob/chrome-headless-esm-tests/karma.conf.js#L145, so it runs as part of the default case in the switch statement.

The browser tests should be running the HTML reporter, so in theory it should "just work" 😉 Please let me know if you run into problems.

coveralls · 2018-01-10T08:09:25Z

Coverage increased (+0.05%) to 90.018% when pulling d4dd5e4 on 38elements:html into c7730a6 on mochajs:master.

coveralls · 2018-01-10T08:15:28Z

Coverage increased (+0.05%) to 90.018% when pulling f396abc on 38elements:html into c7730a6 on mochajs:master.

38elements · 2018-01-10T08:33:08Z

I changed this.:smile:

boneskull · 2018-01-17T04:39:50Z

test/browser-specific/html-reporter.spec.js

+    document.body.appendChild(mochaElem);
+  }
+
+  function sleep (fn, ms) {


this in particular is going to be brittle / susceptible to race conditions. but this test suite is unlike anything else we have, so we don't have the tooling.

all of assertions involving markup in innerHTML are also going to be brittle, but again, need better tooling.

I'm going to grab this PR and test it against saucelabs' browsers. if it is flaky, we'll have to change it. but if not, we'll just merge and deal w/ it later--unless, of course, you feel like pulling in Nightwatch.

Thank you for reviewing.
Since I think I am not going to be able to achieve it,
Would you please grab this pull request ?

boneskull · 2018-01-17T04:55:36Z

test/browser-specific/html-reporter.spec.js

+  }
+
+  function sleep (fn, ms) {
+    return new Promise((resolve) => {


IE11 breaks with these

boneskull

the arrow functions need to be replaced

boneskull

the HTML attributes won't necessarily show in the same order, e.g.:

<li class="test pass fast"><h2>title<span class="duration">100ms</span>
  <a class="replay" href="/context.html?grep=fullTitle">‣</a></h2>
  <pre style="display: none;"><code>body</code></pre>
</li>

vs

<li class="test pass fast"><h2>title<span class="duration">100ms</span>
  <a href="/context.html?grep=fullTitle" class="replay">‣</a></h2>
  <pre style="display: none;"><code>body</code></pre>
</li>

38elements · 2018-01-18T10:50:40Z

Thank you for reviewing.
I will change this within 5 days.

coveralls · 2018-01-20T07:49:57Z

Coverage increased (+0.05%) to 90.018% when pulling a9cd4fd on 38elements:html into 2e7e4c0 on mochajs:master.

38elements · 2018-01-21T12:52:06Z

I replaced the arrow functions and the comparing HTML attributes.
I added es6-promise.
But, I did not test by IE11.

Nokel81 · 2018-03-28T23:10:41Z

Have you managed to test on IE11 yet?

rugk · 2018-08-11T09:16:05Z

Any news here?

rugk · 2018-08-11T15:31:12Z

@38elements So what?

38elements closed this Nov 13, 2017

38elements reopened this Nov 15, 2017

boneskull added area: browser browser-specific qa area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Dec 7, 2017

boneskull suggested changes Jan 9, 2018

View reviewed changes

38elements force-pushed the html branch from a23a483 to d4dd5e4 Compare January 10, 2018 08:03

boneskull reviewed Jan 17, 2018

View reviewed changes

boneskull approved these changes Jan 17, 2018

View reviewed changes

boneskull reviewed Jan 17, 2018

View reviewed changes

boneskull suggested changes Jan 17, 2018

View reviewed changes

38elements added 5 commits January 20, 2018 16:40

Add unit test for html reporter

dc024f3

Fix style

6de66c7

Change jsdom version

b203f6b

Browser test

95decf6

lint

14047d9

38elements force-pushed the html branch from f396abc to 14047d9 Compare January 20, 2018 07:41

38elements added 2 commits January 20, 2018 20:10

Remove arrow function

279b26f

Change test

a9cd4fd

boneskull force-pushed the master branch 2 times, most recently from 4547268 to 7613521 Compare May 4, 2018 16:47

rugk mentioned this pull request Aug 11, 2018

🛠️ Repo: HTML reporter needs tests #3071

Open

rugk mentioned this pull request Aug 11, 2018

No diff in html report #1348

Closed

38elements closed this Aug 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit test for html reporter #3102

Add unit test for html reporter #3102

38elements commented Nov 11, 2017 •

edited

Loading

coveralls commented Nov 11, 2017

coveralls commented Nov 11, 2017

coveralls commented Nov 11, 2017

38elements commented Nov 13, 2017

ScottFreeCode commented Nov 15, 2017

38elements commented Nov 15, 2017 •

edited

Loading

coveralls commented Nov 15, 2017

boneskull commented Dec 7, 2017

boneskull left a comment

coveralls commented Jan 10, 2018

coveralls commented Jan 10, 2018

38elements commented Jan 10, 2018

boneskull Jan 17, 2018

38elements Jan 22, 2018 •

edited

Loading

boneskull Jan 17, 2018

boneskull left a comment

boneskull left a comment

38elements commented Jan 18, 2018

coveralls commented Jan 20, 2018 •

edited

Loading

38elements commented Jan 21, 2018

Nokel81 commented Mar 28, 2018

rugk commented Aug 11, 2018

rugk commented Aug 11, 2018

Add unit test for html reporter #3102

Add unit test for html reporter #3102

Conversation

38elements commented Nov 11, 2017 • edited Loading

Description of the Change

coveralls commented Nov 11, 2017

coveralls commented Nov 11, 2017

coveralls commented Nov 11, 2017

38elements commented Nov 13, 2017

ScottFreeCode commented Nov 15, 2017

38elements commented Nov 15, 2017 • edited Loading

coveralls commented Nov 15, 2017

boneskull commented Dec 7, 2017

boneskull left a comment

Choose a reason for hiding this comment

coveralls commented Jan 10, 2018

coveralls commented Jan 10, 2018

38elements commented Jan 10, 2018

boneskull Jan 17, 2018

Choose a reason for hiding this comment

38elements Jan 22, 2018 • edited Loading

Choose a reason for hiding this comment

boneskull Jan 17, 2018

Choose a reason for hiding this comment

boneskull left a comment

Choose a reason for hiding this comment

boneskull left a comment

Choose a reason for hiding this comment

38elements commented Jan 18, 2018

coveralls commented Jan 20, 2018 • edited Loading

38elements commented Jan 21, 2018

Nokel81 commented Mar 28, 2018

rugk commented Aug 11, 2018

rugk commented Aug 11, 2018

38elements commented Nov 11, 2017 •

edited

Loading

38elements commented Nov 15, 2017 •

edited

Loading

38elements Jan 22, 2018 •

edited

Loading

coveralls commented Jan 20, 2018 •

edited

Loading