-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ Repo: HTML reporter needs tests #3071
Comments
I have branches that do this with Karma that I need to rebase (and see if the issues on Sauce went away or not). Bonus: the test coverage for the browser, while I implemented it for the reporter, theoretically opens the door to browser-specific units tests if we still have anything that would need it (I dunno if all of those were shims we've now gotten rid of) or browser integration tests (e.g. for #1800 (comment)) with alternate Karma settings (something I still need to explore to ensure they're set up right). |
@ScottFreeCode You are still assigned to this even though a PR is there in #3102. |
@rugk seems like the owner has lost interest, perhaps checkout branch, rebase and re-open PR if you are still interested. It sounded close if passes IE11 testing. |
@giltayar do you have any suggestions how to start with this one? |
There is playwright of Microsoft. |
There's no lack of browser automation tools, although not sure this is needed. I would go with a simpler snapshot test (i.e. save the HTML baseline file, and always compare against that). Usually, I'm not a fan of these, but given that we're looking at one or two tests, I think it's the easiest solution. If you do want a browser automation test. Given that there aren't a lot of tests here, I would go with the tried and true: Selenium WebDriver. |
I don't believe this |
Marking this as one I'm interested in, I use Playwright as a Microsoft employee and it's excellent (I'm biased ;) ) but I agree it may not be necessary. Happy to work with whoever wants to get started on this, as I'm currently focusing on some other issues. |
We have decent coverage in most places now. The glaring exception is the HTML reporter, which is completely untested.
Add tests for the HTML reporter.
This will necessitate likely some unit tests and browser-based functional tests. The latter of which we have none of, so we'd need to pull in some extra dependencies to do so. This won't be trivial.
The text was updated successfully, but these errors were encountered: