Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Repo: HTML reporter needs tests #3071

Open
boneskull opened this issue Oct 18, 2017 · 8 comments
Open

🛠️ Repo: HTML reporter needs tests #3071

boneskull opened this issue Oct 18, 2017 · 8 comments
Labels
area: reporters involving a specific reporter area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Contributor

boneskull commented Oct 18, 2017

We have decent coverage in most places now. The glaring exception is the HTML reporter, which is completely untested.

Add tests for the HTML reporter.

This will necessitate likely some unit tests and browser-based functional tests. The latter of which we have none of, so we'd need to pull in some extra dependencies to do so. This won't be trivial.

@boneskull boneskull added status: accepting prs Mocha can use your help with this one! qa labels Oct 18, 2017
@ScottFreeCode
Copy link
Contributor

I have branches that do this with Karma that I need to rebase (and see if the issues on Sauce went away or not). Bonus: the test coverage for the browser, while I implemented it for the reporter, theoretically opens the door to browser-specific units tests if we still have anything that would need it (I dunno if all of those were shims we've now gotten rid of) or browser integration tests (e.g. for #1800 (comment)) with alternate Karma settings (something I still need to explore to ensure they're set up right).

@rugk
Copy link

rugk commented Aug 11, 2018

@ScottFreeCode You are still assigned to this even though a PR is there in #3102.

@craigtaub
Copy link
Contributor

@rugk seems like the owner has lost interest, perhaps checkout branch, rebase and re-open PR if you are still interested. It sounded close if passes IE11 testing.

@craigtaub craigtaub added the area: reporters involving a specific reporter label Jan 19, 2020
@juergba juergba pinned this issue Jun 13, 2021
@juergba
Copy link
Contributor

juergba commented Jun 13, 2021

@giltayar do you have any suggestions how to start with this one?
We also have some funds available we could invest.

@juergba
Copy link
Contributor

juergba commented Jun 13, 2021

There is playwright of Microsoft.
They also offer their own test runner for Node. Folio, "a highly customizable test framework", available in preview.
This is going to be a very competitive player in test frameworks.

@giltayar
Copy link
Contributor

There's no lack of browser automation tools, although not sure this is needed. I would go with a simpler snapshot test (i.e. save the HTML baseline file, and always compare against that). Usually, I'm not a fan of these, but given that we're looking at one or two tests, I think it's the easiest solution.

If you do want a browser automation test. Given that there aren't a lot of tests here, I would go with the tried and true: Selenium WebDriver.

@SmokeDawg92967
Copy link

I don't believe this

@juergba juergba unpinned this issue Aug 10, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title html reporter needs tests 🛠️ Repo: HTML reporter needs tests Dec 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg added area: repository tooling concerning ease of contribution and removed area: qa labels Jan 2, 2024
@mark-wiemer
Copy link
Contributor

Marking this as one I'm interested in, I use Playwright as a Microsoft employee and it's excellent (I'm biased ;) ) but I agree it may not be necessary. Happy to work with whoever wants to get started on this, as I'm currently focusing on some other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: reporters involving a specific reporter area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!
Projects
None yet
Development

No branches or pull requests

9 participants