-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Use mamba in CIs #11471
MAINT: Use mamba in CIs #11471
Conversation
Okay, just asking it to install I'm going to try it now with better proper channel priority (as suggested in the |
... apparently this works on macOS but not Linux. I'm tempted to close for now and revisit in a few months hoping some conda, mamba, and/or |
using mambaforge fixed compat-old and compat-minimal. Only notebook is failing now, with:
If I'm reading it correctly, those versions of those packages simply don't allow python 3.10 (though they do allow 3.11?) Should I try using 3.11 in the notebook image, or is that known to fail for other reasons? |
All green! mambaforge FTW. @larsoner merge if happy. |
actually, we should check the job timings. maybe I'm reading things wrong but it looks like the usage minutes went up for the last run of CIs on this PR, when compared to recent runs on #11473 (a randomly chosen PR for comparison). IDK how to query GH Actions timings efficiently though, maybe you do? |
Okay I restarted linux_conda, compat_minimal, and compat_old and will check against runs from #11479 which are happening concurrently |
Timings are 6min / 2min / 2min, respectively, on this PR, and 8min / 1min / 1min on #11479 (roughly). But macOS improves from 11 to 7 min on this PR, too, which is nice. Since it's at least as fast overall and tests |
* upstream/main: (46 commits) Fix docstrings by replacing str with path-like and fix double backticks for formatting (mne-tools#11499) Use pathlib.Path instead of os.path to handle files and folders [circle deploy] (mne-tools#11473) MAINT: Fix Circle [circle deploy] (mne-tools#11497) MAINT: Use mamba in CIs (mne-tools#11471) Updating documentation to clarify full vs half-bandwidth and defaults in time_frequency.multitaper.py (mne-tools#11479) Fix typo in tutorial (mne-tools#11498) Typo fix and added colons before code (mne-tools#11496) [MRG] ENH/DOC: demo custom spectrum creation (mne-tools#11493) Accept only left-clicks for adding annotations (mne-tools#11491) [BUG, MRG] Fix pial surface loading, logging in locate_ieeg (mne-tools#11489) [ENH] Added unit_role to add non-breaking space between magnitude and units (mne-tools#11469) MAINT: Fix CircleCI build (mne-tools#11488) [DOC] Updated decoding.SSD documentation and internal variable naming (mne-tools#11475) Typo fix (mne-tools#11485) [MRG] Forward argument axes from plot_sensors to DigMontage.plot (mne-tools#11470) [MRG] Improve error message raised on channels missing from DigMontage (mne-tools#11472) MAINT: Deal with pkg_resources usage bugs (mne-tools#11478) Add object array support and docstring (mne-tools#11465) [ENH] Adjusted SSD algorithm to support non-full rank data (mne-tools#11458) [BUG] fix nibabel reference (mne-tools#11467) ...
* upstream/main: (264 commits) BUG: Fix deprecated API usage in example (mne-tools#11512) Deprecate 'kind' and 'path' in favor of 'fname' in the layout reader (mne-tools#11500) EGI/MFF events outside EEG recording should not break the code (mne-tools#11505) fixed annotations error on export (mne-tools#11435) DOC: Update installer links [skip azp] [skip actions] [skip cirrus] (mne-tools#11506) BUG: updates for MPL 3.7 compatibility (mne-tools#11409) Fix docstrings by replacing str with path-like and fix double backticks for formatting (mne-tools#11499) Use pathlib.Path instead of os.path to handle files and folders [circle deploy] (mne-tools#11473) MAINT: Fix Circle [circle deploy] (mne-tools#11497) MAINT: Use mamba in CIs (mne-tools#11471) Updating documentation to clarify full vs half-bandwidth and defaults in time_frequency.multitaper.py (mne-tools#11479) Fix typo in tutorial (mne-tools#11498) Typo fix and added colons before code (mne-tools#11496) [MRG] ENH/DOC: demo custom spectrum creation (mne-tools#11493) Accept only left-clicks for adding annotations (mne-tools#11491) [BUG, MRG] Fix pial surface loading, logging in locate_ieeg (mne-tools#11489) [ENH] Added unit_role to add non-breaking space between magnitude and units (mne-tools#11469) MAINT: Fix CircleCI build (mne-tools#11488) [DOC] Updated decoding.SSD documentation and internal variable naming (mne-tools#11475) Typo fix (mne-tools#11485) ...
One way to move toward being able to recommend mamba is by including it inI made our solvers useenvironment.yml
, so I added it here.mamba
by including it in thesetup-miniconda
action according to the instructions here. Note that they even say it's experimental, and I'm assuming that's becausemamba
is moreso than the action itself:FWIW @drammock Azure was already using
mamba env update
on Windows, IIRC to speed up the solve time.