-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] Only admins can create new user #9700
Conversation
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Signed-off-by: Gabriel Fu <[email protected]>
Documentation preview for 52dd2b3 will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: Gabriel Fu <[email protected]>
Co-authored-by: Harutaka Kawamura <[email protected]> Signed-off-by: Gabriel Fu <[email protected]>
Do we need to remove the signup form? |
@harupy I think it's still helpful if the admin can create users via UI |
@gabrielfu Got it. Is it possible to make the singup page an admin-only page? |
@harupy makes sense, let me change it |
Signed-off-by: Gabriel Fu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the feature adjustment @gabrielfu ! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Gabriel Fu <[email protected]> Co-authored-by: Harutaka Kawamura <[email protected]>
Related Issues/PRs
#9669What changes are proposed in this pull request?
Only admins are allowed to create new users, to prevent potential attackers from creating lots of users.
How is this patch tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Only admins are allowed to create new users, to prevent potential attackers from creating lots of users.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes