Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of samples per queries with equal issue mode #2039

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix reporting of samples per queries with equal issue mode #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7428c8
Fix reporting of samples per queries with equal issue mode
pgmpablo157321 Jan 15, 2025
274733b
Update VERSION.txt
arjunsuresh Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion loadgen/VERSION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.0.10
5.0.11
2 changes: 1 addition & 1 deletion loadgen/loadgen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ std::vector<QueryMetadata> GenerateQueries(
}
}

LogDetail([count = queries.size(), spq = settings.samples_per_query,
LogDetail([count = queries.size(), spq = samples_per_query,
duration = timestamp.count()](AsyncDetail& detail) {
#if USE_NEW_LOGGING_FORMAT
MLPERF_LOG(detail, "generated_query_count", count);
Expand Down
1 change: 1 addition & 0 deletions loadgen/mlperf.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dlrm.*.performance_sample_count_override = 204800
dlrm-v2.*.performance_sample_count_override = 204800
rnnt.*.performance_sample_count_override = 2513
gptj.*.performance_sample_count_override = 13368
mixtral-8x7b.*.performance_sample_count_override = 15000
llama2-70b.*.performance_sample_count_override = 24576
llama3_1-405b.*.performance_sample_count_override = 8313
stable-diffusion-xl.*.performance_sample_count_override = 5000
Expand Down
6 changes: 6 additions & 0 deletions loadgen/test_settings_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,12 @@ void TestSettingsInternal::LogSummary(AsyncSummary &summary) const {
summary("performance_issue_same : ", performance_issue_same);
summary("performance_issue_same_index : ", performance_issue_same_index);
summary("performance_sample_count : ", performance_sample_count);
if (sample_concatenate_permutation){
summary("WARNING: sample_concatenate_permutation was set to true. \n"
"Generated samples per query might be different as the one in the setting.\n"
"Check the generated_samples_per_query line in the detailed log for the real\n"
"samples_per_query value");
}
}

} // namespace loadgen
Expand Down
Loading