Fix reporting of samples per queries with equal issue mode #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
pgmpablo157321
force-pushed
the
fix_samples_per_query_report
branch
from
329f43c to
e7428c8
Compare
arjunsuresh
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you @pgmpablo157321 for the fix. The tests are passing now - they were failing earlier due to an issue in the ck repository.
|
@pgmpablo157321: So, is this ready to merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken_detail.txt
fixed_detail.txt
See field generated_samples_per_query: padded to be multiple of 128