Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight Tree Printing #170

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Weight Tree Printing #170

merged 1 commit into from
Jul 2, 2024

Conversation

vcfxb
Copy link
Contributor

@vcfxb vcfxb commented Jul 1, 2024

Provide CLI functionality to print the resolved weights used in analysis.

Closes #28

@vcfxb vcfxb added type: enhancement New feature or request type: ui UI-related changes that should get heightened review. labels Jul 1, 2024
@vcfxb vcfxb added this to the 3.4.0 milestone Jul 1, 2024
@vcfxb vcfxb requested review from alilleybrinker and j-lanson July 1, 2024 20:01
@vcfxb vcfxb self-assigned this Jul 1, 2024
@vcfxb vcfxb requested a review from mchernicoff July 1, 2024 20:02
@alilleybrinker
Copy link
Collaborator

Testing locally now!

Copy link
Collaborator

@alilleybrinker alilleybrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to hc scoring, otherwise LGTM!

alilleybrinker
alilleybrinker previously approved these changes Jul 1, 2024
@vcfxb vcfxb dismissed alilleybrinker’s stale review July 1, 2024 20:27

The merge-base changed after approval.

@vcfxb vcfxb force-pushed the venus/print-score-tree branch from a09b627 to 9aa945c Compare July 1, 2024 20:27
@vcfxb vcfxb requested a review from alilleybrinker July 1, 2024 20:33
@vcfxb vcfxb force-pushed the venus/print-score-tree branch from 69ed869 to 4f472b9 Compare July 1, 2024 20:57
@vcfxb
Copy link
Contributor Author

vcfxb commented Jul 1, 2024

It took 2 attempts at squashing and force-pushing but I think this is finally properly squashed and ready to merge.

@alilleybrinker alilleybrinker merged commit c69527f into main Jul 2, 2024
9 checks passed
@vcfxb vcfxb deleted the venus/print-score-tree branch July 2, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request type: ui UI-related changes that should get heightened review.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a command to view scoring breakdown
2 participants