You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now you can configure Hipcheck to produce scores based on weights for different analyses, but you can't really see the calculated percentages for each leaf of the scoring tree, which makes it difficult to understand how scores are actually calculated. It would be really great if there were a command to see this broken down, and ideally also a way to see it in the output (both human and machine readable) when you run analyses.
Define new AnalysisReport struct to abstract value/threshold predicate and move into Pass/Fail enumeration.
Update analyses to use new AnalysisReport.
Move decision to run/skip analysis out of X_analysis() functions and into the HipCheck core
Change AnalysisResults to be a HashMap that maps analysis labels to updated AnalysisReport objects
Create WeightTree object and provider for getting a normalized version based on config
Update scoring to combine updated AnalysisResults map + normalized WeightTree to produce a ScoreTree
Update errored analyses to act as Fail for the purpose of score calculation, and notify user of errors
Add ability to print what percentage of the total score each analysis accounted for by walking the ScoreTree
The text was updated successfully, but these errors were encountered:
Hey @vcfxb, with Julian out for a bit, think you could bring this over the finish line? With the introduction of the weight tree abstraction we should have all the underlying mechanisms in place to add the new subcommand. I'm happy to sync to discuss what's left for this.
Right now you can configure Hipcheck to produce scores based on weights for different analyses, but you can't really see the calculated percentages for each leaf of the scoring tree, which makes it difficult to understand how scores are actually calculated. It would be really great if there were a command to see this broken down, and ideally also a way to see it in the output (both human and machine readable) when you run analyses.
AnalysisReport
struct to abstract value/threshold predicate and move into Pass/Fail enumeration.AnalysisReport
.X_analysis()
functions and into the HipCheck coreAnalysisResults
to be aHashMap
that maps analysis labels to updatedAnalysisReport
objectsWeightTree
object and provider for getting a normalized version based on configAnalysisResults
map + normalizedWeightTree
to produce aScoreTree
Fail
for the purpose of score calculation, and notify user of errorsScoreTree
The text was updated successfully, but these errors were encountered: