Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnetwork support #166

Merged
merged 5 commits into from
Jun 12, 2017
Merged

Subnetwork support #166

merged 5 commits into from
Jun 12, 2017

Conversation

Wyosotis
Copy link
Contributor

@Wyosotis Wyosotis commented Apr 28, 2017

Hello!

Please review this pull request for #164 issue.

@Wyosotis
Copy link
Contributor Author

Wyosotis commented Jun 8, 2017

Could someone review it please?
fog-google with subnetwork support has been released.

Rake test results (with this small fix) are below:

lkuntar@lkuntar-VirtualBox:~/workspace/forks/vagrant-google$ bundle exec rake
/usr/bin/ruby2.2 -S rspec test/unit/common/config_test.rb --color
.................................................................

Deprecation Warnings:

Use of rspec-core's `its` method is deprecated. Use the rspec-its gem instead. Called from /home/lkuntar/workspace/forks/vagrant-google/test/unit/common/config_test.rb:33:in `block (2 levels) in <top (required)>'.
Use of rspec-core's `its` method is deprecated. Use the rspec-its gem instead. Called from /home/lkuntar/workspace/forks/vagrant-google/test/unit/common/config_test.rb:34:in `block (2 levels) in <top (required)>'.
Use of rspec-core's `its` method is deprecated. Use the rspec-its gem instead. Called from /home/lkuntar/workspace/forks/vagrant-google/test/unit/common/config_test.rb:35:in `block (2 levels) in <top (required)>'.
Too many uses of deprecated 'Use of rspec-core's `its` method'. Pass `--deprecation-out` or set `config.deprecation_stream` to a file for full output.

`be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) or `be false` (for exact `== false` equality) instead. Called from /home/lkuntar/workspace/forks/vagrant-google/test/unit/common/config_test.rb:46:in `block (3 levels) in <top (required)>'.


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

45 deprecation warnings total

Finished in 0.45853 seconds
65 examples, 0 failures

@erjohnso
Copy link
Collaborator

Thanks for this @Wyosotis - looks good to me!

@erjohnso erjohnso merged commit 9a45af3 into mitchellh:master Jun 12, 2017
@Wyosotis
Copy link
Contributor Author

@erjohnso thank you for reviewing it.
May I know when approximately a new release would appear? Because the new features that have been merged since last release (e.g. SSH over private IP), considerably improve experience with vagrant-google in real tasks.

@Temikus
Copy link
Collaborator

Temikus commented Jul 4, 2017

@Wyosotis So it looks like releasing a new version is not entirely trivial due to some dependency issues and the fact that bundler now disallows the hack that Vagrant uses to load up plugins in development.

I'll need some time to wrangle with it and do a prerelease.

I expect to address this sometime this/next week.

@Temikus
Copy link
Collaborator

Temikus commented Jul 18, 2017

@Wyosotis Ok, this is even less trivial than I thought, it actually interferes with plugin loading itself so I cannot even do a rollback without breaking recent versions of vagrant it seems.

I'll spend more time figuring this out this Friday, hopefully I'll be able to find a workaround which doesn't require a lot of rewriting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants