Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake tests failed because of deprecated function #165

Closed
wants to merge 3 commits into from

Conversation

Wyosotis
Copy link
Contributor

Method `last_comment' is deprecated.

lkuntar@lkuntar-VirtualBox:~/workspace/forks/vagrant-google$ bundle exec rake --trace
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00000003a090d0>
/var/lib/gems/2.2.0/gems/rspec-core-2.99.2/lib/rspec/core/rake_task.rb:143:in `initialize'
/home/lkuntar/workspace/forks/vagrant-google/tasks/test.rake:5:in `new'
/home/lkuntar/workspace/forks/vagrant-google/tasks/test.rake:5:in `block in <top (required)>'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/task_manager.rb:205:in `in_namespace'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/dsl_definition.rb:140:in `namespace'
/home/lkuntar/workspace/forks/vagrant-google/tasks/test.rake:4:in `<top (required)>'
/home/lkuntar/workspace/forks/vagrant-google/Rakefile:29:in `load'
/home/lkuntar/workspace/forks/vagrant-google/Rakefile:29:in `block in <top (required)>'
/home/lkuntar/workspace/forks/vagrant-google/Rakefile:28:in `each'
/home/lkuntar/workspace/forks/vagrant-google/Rakefile:28:in `<top (required)>'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/rake_module.rb:28:in `load'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/rake_module.rb:28:in `load_rakefile'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:687:in `raw_load_rakefile'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:96:in `block in load_rakefile'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:178:in `standard_exception_handling'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:95:in `load_rakefile'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:79:in `block in run'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:178:in `standard_exception_handling'
/var/lib/gems/2.2.0/gems/rake-12.0.0/lib/rake/application.rb:77:in `run'
/var/lib/gems/2.2.0/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
/usr/local/bin/rake:23:in `load'
/usr/local/bin/rake:23:in `<main>'

@Temikus
Copy link
Collaborator

Temikus commented Apr 25, 2017

@Leila-Kuntar Thanks for this!

See comment.

Copy link
Collaborator

@Temikus Temikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wyosotis PTAL. Apologies, I didn't click the "submit review" here. I seem to be on a roll this week, sorry about that...

Gemfile Outdated
# This is a restriction to avoid an error "undefined method 'last_comment'" which is deprecated
# https://github.com/ruby/rake/issues/116
# Remove it after update rspec-core-2.99.2 to version greater or equal to 3.4.4
gem 'rake', '< 11'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be in "development" spec group, no?
I don't want us to have a hard dependency on rake version in the driver.

@Wyosotis
Copy link
Contributor Author

Wyosotis commented May 19, 2017

@Temikus PTAL
I have updated it but now there is other problem. The file lib/vagrant-google/config.rb has been changed a few days ago. So rake tests fail due to changes in pull #167 (65 examples, 6 failures).

@Wyosotis Wyosotis mentioned this pull request Jun 6, 2017
@Temikus Temikus mentioned this pull request Jul 21, 2017
@erjohnso
Copy link
Collaborator

Thanks @Wyosotis! @Temikus rolled this fix into #174 and we cut a new release.

@erjohnso erjohnso closed this Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants