This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Add task list params #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason, the first column remains empty for me. Even after starting from scratch with Also, the tasks list seems to be empty now 🤔 Problem seems to be that I'm getting normalizer jobs instead of Boefje jobs when requesting |
|
@Lisser commit in the mula branch should fix this problem |
|
Awesome. Works for me now! |
|
Can we use a lazy Paginator object here to apply pagination in the same style as the OOIList paginator? https://github.com/minvws/nl-kat-rocky/blob/main/rocky/views/mixins.py#L153 |
Lisser
reviewed
Jan 9, 2023
# Conflicts: # rocky/views/ooi_detail.py
underdarknl
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a partial scans/tasks lists view, that (according to designs) can be used on: ooi detail page, boefje detail page, and task/scans page. Since, the designs show that the functionality is the same across these pages, it made sense to create one partial and include these in the templates. At the moment in this PR it is implemented on the ooi detail and plugin detail page.
Open questions:
Since there are different strategies for implementing forms/pagination throughout rocky the main question is if this implementation and location of files etc. is the way forward and correct for the future. With this PR I don't want to introduce yet another new implementation.
In the designs, the table's first column is the object name. It might not make sense in the context of an ooi detail page, since the name is already present. Additionally, there is a search field for an object name, in the context of a ooi detail this would make not much sense.
Now form fields are being passed to the template context. This is done to make a differentiation between fields in the filter form fields that need to remain as query parameters when submitting the filter form. This could potentially be a django form, the question is if this is desirable.
How to test/view: