Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

[Feature] task list filters #16

Merged
merged 5 commits into from
Jan 11, 2023
Merged

[Feature] task list filters #16

merged 5 commits into from
Jan 11, 2023

Conversation

jpbruinsslot
Copy link
Contributor

@jpbruinsslot jpbruinsslot commented Dec 15, 2022 •
edited
Loading

Closes #22

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jpbruinsslot jpbruinsslot self-assigned this Dec 19, 2022
@jpbruinsslot jpbruinsslot marked this pull request as ready for review December 20, 2022 10:00
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner December 20, 2022 10:00
@jpbruinsslot jpbruinsslot mentioned this pull request Dec 29, 2022
Merged
@jpbruinsslot jpbruinsslot changed the base branch from main to release-1.4 December 29, 2022 10:44
@jpbruinsslot jpbruinsslot changed the base branch from release-1.4 to main December 29, 2022 10:45
@jpbruinsslot jpbruinsslot linked an issue Dec 29, 2022 that may be closed by this pull request
[Feature] Add additional filters for the tasks list endpoint #22
Closed
4 tasks
ammar92
ammar92 reviewed Dec 29, 2022
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! I have a few remarks that could be considered. Let me know what you think

@jpbruinsslot
Copy link
Contributor Author

@ammar92 again thanks for the review! Updated it according to your suggestions

Donnype
Donnype previously approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good stuff!

@jpbruinsslot jpbruinsslot force-pushed the feature/task-list-filters branch from 1d3f61e to 0c15b9a Compare January 5, 2023 08:40
Darwinkel
Darwinkel previously approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@Darwinkel Darwinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There do not appear to be any functional regressions.

@underdarknl underdarknl merged commit f6d4e2c into main Jan 11, 2023
@underdarknl underdarknl deleted the feature/task-list-filters branch January 11, 2023 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammar92 ammar92 ammar92 left review comments

@underdarknl underdarknl underdarknl approved these changes

@Darwinkel Darwinkel Darwinkel left review comments

@Donnype Donnype Donnype left review comments

Assignees

@jpbruinsslot jpbruinsslot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add additional filters for the tasks list endpoint
6 participants
@jpbruinsslot @CLAassistant @underdarknl @ammar92 @Darwinkel @Donnype