Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated template file to respect environment prefixes in docs #2317

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Updated template file to respect environment prefixes in docs #2317

merged 2 commits into from
Jan 11, 2024

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Jan 11, 2024

Changes

This implements environment prefixes using the template file.

Issue link

Possible fixes and closes #2284

Demo

image

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@ammar92 ammar92 added bug Something isn't working documentation Improvements or additions to documentation labels Jan 11, 2024
@ammar92 ammar92 marked this pull request as ready for review January 11, 2024 13:17
@ammar92 ammar92 requested a review from a team as a code owner January 11, 2024 13:17
@ammar92 ammar92 merged commit 0da6b58 into main Jan 11, 2024
7 checks passed
@ammar92 ammar92 deleted the fix/settings-docs-template branch January 11, 2024 14:36
jpbruinsslot added a commit that referenced this pull request Jan 18, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/flexible-scheduling
8e78f9c 
* main: (21 commits)
  Add IPv6 config to docker-compose.yml (#2256)
  Remove IPs with zero vulnerabilities (#2319)
  Translations update from Hosted Weblate (#2311)
  Chore/update pr template with comments (#2305)
  Sector report summary - Best and worst scoring security checks (#2312)
  Remove icons from compliance issue table (#2340)
  More ulimits for buggy celery (#2338)
  Remove smartphone from bug report template (#2334)
  add meta / cache hash for rpki boefje to raw output (#2255)
  Add max fds ulimit to octopoes api worker (#2327)
  Fix multiple Debian issues (#2283)
  Fix/upgrade jinja2 (#2326)
  Remove preselection from multireport flow (#2318)
  Updated template file to respect environment prefixes in docs (#2317)
  fix zero division (#2298)
  List item behaviour (#2281)
  Translations update from Hosted Weblate (#2279)
  Fixed invalid type usage in `get_rabbit_channel` and `close_rabbit_channel` (#2280)
  Translations update from Hosted Weblate (#2261)
  Fix export buttons report (#2259)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkers dekkers dekkers approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammar92 @dekkers