Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zero division #2298

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix zero division #2298

merged 1 commit into from
Jan 9, 2024

Conversation

noamblitz
Copy link
Contributor

Changes

Fixes a zero division in error when the total is zero in basic security

Issue link

Closes #2297

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@noamblitz noamblitz requested a review from a team as a code owner January 9, 2024 10:58
@underdarknl underdarknl merged commit 6d2f443 into main Jan 9, 2024
20 checks passed
@underdarknl underdarknl deleted the fix/zero-devision-multi-report branch January 9, 2024 11:05
jpbruinsslot added a commit that referenced this pull request Jan 18, 2024
* main: (21 commits)
  Add IPv6 config to docker-compose.yml (#2256)
  Remove IPs with zero vulnerabilities (#2319)
  Translations update from Hosted Weblate (#2311)
  Chore/update pr template with comments (#2305)
  Sector report summary - Best and worst scoring security checks (#2312)
  Remove icons from compliance issue table (#2340)
  More ulimits for buggy celery (#2338)
  Remove smartphone from bug report template (#2334)
  add meta / cache hash for rpki boefje to raw output (#2255)
  Add max fds ulimit to octopoes api worker (#2327)
  Fix multiple Debian issues (#2283)
  Fix/upgrade jinja2 (#2326)
  Remove preselection from multireport flow (#2318)
  Updated template file to respect environment prefixes in docs (#2317)
  fix zero division (#2298)
  List item behaviour (#2281)
  Translations update from Hosted Weblate (#2279)
  Fixed invalid type usage in `get_rabbit_channel` and `close_rabbit_channel` (#2280)
  Translations update from Hosted Weblate (#2261)
  Fix export buttons report (#2259)
  ...
dekkers pushed a commit that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sector report - ZeroDevisionError
2 participants