This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Fix nmap schema and add test showing integers are not yet supported #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
previously approved these changes
Jan 11, 2023
Donnype
changed the title
underdarknl
approved these changes
Jan 16, 2023
|
@Donnype if the fix for the integer handling is for now to change all integer fields to string, this should also be modified for #58. However, I think integer fields should be supported in the end to prevent end-users already in the front-end from entering invalid values |
|
@zcrt Good catch! See #68. And, agreed, see minvws/nl-kat-coordination#137 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.