Change mock repository to use strings as the sql implementation does

minvws · Jan 11, 2023 · 37bf547 · 37bf547
1 parent b3fc80b
commit 37bf547
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/boefjes/katalogus/storage/memory.py b/boefjes/katalogus/storage/memory.py
@@ -74,10 +74,10 @@ def get_all(self, organisation_id: str, plugin_id: str) -> Dict[str, str]:
         return {k.split(".", maxsplit=1)[1]: v for k, v in self._data[organisation_id].items() if plugin_id in k}
 
     def create(self, key: str, value: str, organisation_id: str, plugin_id: str) -> None:
-        self._data[organisation_id][f"{plugin_id}.{key}"] = value
+        self._data[organisation_id][f"{plugin_id}.{key}"] = str(value)
 
     def update_by_key(self, key: str, value: str, organisation_id: str, plugin_id: str) -> None:
-        self._data[organisation_id][f"{plugin_id}.{key}"] = value
+        self._data[organisation_id][f"{plugin_id}.{key}"] = str(value)
 
     def delete_by_key(self, key: str, organisation_id: str, plugin_id: str) -> None:
         del self._data[organisation_id][f"{plugin_id}.{key}"]

diff --git a/boefjes/katalogus/tests/test_plugin_service.py b/boefjes/katalogus/tests/test_plugin_service.py
@@ -217,5 +217,12 @@ def test_adding_integer_settings_with_faulty_value_given_constraints(self):
 
         self.assertIn("'24' is not of type 'integer'", ctx.exception.message)
 
+        self.service.settings_storage.update_by_key("api_key", 24, self.organisation, plugin_id)  # not multiple of 10
+
+        with self.assertRaises(SettingsNotConformingToSchema) as ctx:
+            self.service.update_by_id("test-repo-2", plugin_id, self.organisation, True)
+
+        self.assertIn("'24' is not of type 'integer'", ctx.exception.message)
+
         plugin = self.service.by_plugin_id(plugin_id, self.organisation)
         self.assertFalse(plugin.enabled)