Implement basic repo registration with gitlab #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
gitlab-register-repo
branch
2 times, most recently
from
df53191 to
c430e61
Compare
JAORMX
force-pushed
the
upstream-entities
branch
from
013133b to
19b449b
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
from
c430e61 to
f6a9206
Compare
JAORMX
force-pushed
the
upstream-entities
branch
2 times, most recently
from
cdbee74 to
9b7848a
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
2 times, most recently
from
2af2905 to
b80f945
Compare
JAORMX
force-pushed
the
upstream-entities
branch
from
9b7848a to
dafe2ee
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
from
b80f945 to
26f1c61
Compare
JAORMX
force-pushed
the
upstream-entities
branch
2 times, most recently
from
627dbef to
b72ed16
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
from
26f1c61 to
4d5cff9
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
from
4d5cff9 to
b3975ff
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
from
b3975ff to
d53b666
Compare
JAORMX
force-pushed
the
gitlab-register-repo
branch
2 times, most recently
from
9a6fad5 to
dcd6099
Compare
This adds the needed pieces for the GitLab provider to do entity registration. In the case of repos, this was the implementation of the repo lister trait. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
gitlab-register-repo
branch
from
dcd6099 to
5d2e102
Compare
blkt
approved these changes
Sep 13, 2024
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create properties: %w", err) | ||
| } | ||
|
|
||
| return getByProps.Merge(outProps), nil |
There was a problem hiding this comment.
question (non-blocking): why is this merge no longer necessary?
There was a problem hiding this comment.
It's an implementation detail. It was necessary because I was forming merging what was incoming to what I'm forming here. Now, outProps gets populated explicitly with everything that's needed, so I no longer needed the merge. It's just a little more efficient to not need to iterate over the incoming properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the needed pieces for the GitLab provider to do entity
registration. In the case of repos, this was the implementation of the
repo lister trait.
Closes: #4331
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: