Fix tolerating stale data in properties service (#4478)

The condition was wrong... This makes it so that data is marked as valid if the time-range is fine or if we can tolerate it. Signed-off-by: Juan Antonio Osorio <[email protected]>
mindersec · Sep 13, 2024 · 6829aa5 · 6829aa5
1 parent 944ac39
commit 6829aa5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/entities/properties/service/helpers.go b/internal/entities/properties/service/helpers.go
@@ -188,8 +188,8 @@ func (ps *propertiesService) areDatabasePropertiesValid(
 
 func (ps *propertiesService) isDatabasePropertyValid(
 	dbProp db.Property, opts *ReadOptions) bool {
-	if ps.entityTimeout == bypassCacheTimeout || opts.canTolerateStaleData() {
+	if ps.entityTimeout == bypassCacheTimeout {
 		return false
 	}
-	return time.Since(dbProp.UpdatedAt) < ps.entityTimeout
+	return time.Since(dbProp.UpdatedAt) < ps.entityTimeout || opts.canTolerateStaleData()
 }