Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo migration from PR #4065 #4129

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Redo migration from PR #4065 #4129

merged 2 commits into from
Aug 14, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Aug 13, 2024

Refer to PR #4065 for a description of the change. This was merged in but had to be rolled back due to a bug. That bug was fixed in PR #4124. As part of this roll out. Part of migration script 88 needs to be repeated to fix any rows affected by that bug before applying it.

Validated against staging and rolled back.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb marked this pull request as ready for review August 13, 2024 16:10
@dmjb dmjb requested a review from a team as a code owner August 13, 2024 16:10
jhrozek
jhrozek previously approved these changes Aug 13, 2024
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to rebase and increase the migration number. Otherwise LGTM

dmjb added 2 commits August 14, 2024 09:47
Refer to PR #4065 for a description of the change. This was merged in
but had to be rolled back due to a bug. That bug was fixed in PR #4124.
As part of this roll out. Part of migration script 88 needs to be
repeated to fix any rows affected by that bug before applying it.
@dmjb dmjb force-pushed the re-apply-migration branch from ae39ee2 to e8cb018 Compare August 14, 2024 08:48
@dmjb dmjb merged commit a581a94 into main Aug 14, 2024
21 checks passed
@dmjb dmjb deleted the re-apply-migration branch August 14, 2024 09:03
@coveralls
Copy link

Coverage Status

coverage: 53.939% (-0.009%) from 53.948%
when pulling e8cb018 on re-apply-migration
into ca27c5e on main.

psekar pushed a commit to tinytrail/minder that referenced this pull request Aug 15, 2024
Refer to PR mindersec#4065 for a description of the change. This was merged in
but had to be rolled back due to a bug. That bug was fixed in PR mindersec#4124.
As part of this roll out. Part of migration script 88 needs to be
repeated to fix any rows affected by that bug before applying it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants