-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change rule_evaluations upsert to set migrated
to true
#4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query is always called after an upsert into the evaluation history table, so migrated should always be set to true. Due to the lack of the update in the `ON CONFLICT DO UPDATE` clause, we ran into a situation where unmigrated rows in rule_evaluations were being implicitly migrated by the policy migration (i.e. the code was creating a corresponding row in evaluation_rule_entities) but the migrated flag was still set to false. The migration script would then attempt to copy the data to the evaluation_rule_entities table, which would error out because the data for that rule/entity pair already existed.
Red build is caused by the known OpenFGA CVE issue, and does not relate to the changes here. |
blkt
approved these changes
Aug 12, 2024
psekar
pushed a commit
to tinytrail/minder
that referenced
this pull request
Aug 15, 2024
) This query is always called after an upsert into the evaluation history table, so migrated should always be set to true. Due to the lack of the update in the `ON CONFLICT DO UPDATE` clause, we ran into a situation where unmigrated rows in rule_evaluations were being implicitly migrated by the policy migration (i.e. the code was creating a corresponding row in evaluation_rule_entities) but the migrated flag was still set to false. The migration script would then attempt to copy the data to the evaluation_rule_entities table, which would error out because the data for that rule/entity pair already existed.
psekar
pushed a commit
to tinytrail/minder
that referenced
this pull request
Aug 15, 2024
Refer to PR mindersec#4065 for a description of the change. This was merged in but had to be rolled back due to a bug. That bug was fixed in PR mindersec#4124. As part of this roll out. Part of migration script 88 needs to be repeated to fix any rows affected by that bug before applying it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query is always called after an upsert into the evaluation history table, so migrated should always be set to true. Due to the lack of the update in the
ON CONFLICT DO UPDATE
clause, we ran into a situation where unmigrated rows in rule_evaluations were being implicitly migrated by the policy migration (i.e. the code was creating a corresponding row in evaluation_rule_entities) but the migrated flag was still set to false. The migration script would then attempt to copy the data to the evaluation_rule_entities table, which would error out because the data for that rule/entity pair already existed.Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: