Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Persist checkpoints in evaluation history db" #4067

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Aug 2, 2024

Reverts #4059 because it broke staging (potential nil reference)

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner August 2, 2024 13:53
@rdimitrov rdimitrov merged commit 6aeb619 into main Aug 2, 2024
21 of 22 checks passed
@rdimitrov rdimitrov deleted the revert-4059-checkpoint-history branch August 2, 2024 14:01
@coveralls
Copy link

Coverage Status

coverage: 54.356% (-0.04%) from 54.4%
when pulling 0427003 on revert-4059-checkpoint-history
into 77946ac on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants